This pull request fixes issues with free/busy calendar in Thunderbird Lightning (and possibly other) client.

Patch description here: https://help.egroupware.org/t/bug-in-free-busy-request-handling-with-thunderbird-lightning-fixed-with-patch-attached/73300

Current Nextmatch Lettersearch is hardcoded to loop through the latin alphabet.

String added as setting in Nextmatch options, which will contain comma-separated letters for custom lettersearch. This proved useful for us since we wanted to include greek letters as well, and I think this approach is dynamic enough to be merged.

Error examples: [Thu Jan 03 13:11:34.043522 2019] [:error] [pid 18181] [client 192.168.1.100:38306] PHP Warning: array_intersect(): Argument #2 is not an array in /usr/share/egroupware/calendar/inc/class.calendar_groupdav.inc.php on line 818, referer: http://egroupware/egroupware/groupdav.php/ABC/calendar/ [Thu Jan 03 13:59:41.125066 2019] [:error] [pid 18364] [client 192.168.1.100:40350] PHP Warning: Invalid argument supplied for foreach() in /usr/share/egroupware/api/src/Etemplate/Widget/Nextmatch.php on line 314, referer: http://egroupware/egroupware/index.php?cd=yes

Erste Fehlermeldung auftaucht wenn ein Termin mit wiederholung über Gruppe via CalDAV abgefragt werden. Im EGroupware ist aber Terminkette sichtbar

Google Chrome returns this error when using EGroupware on mobile: VM6367 fw_mobile.js:487 Uncaught (in promise) DOMException: play() failed because the user didn't interact with the document first. https://goo.gl/xX8pDD

Unable to call ./filemanager/cli.php from cmd-line because classes won't be resolved since autoloading from cli doesn't work.

--> include_once for autoload.php

it looks like the if-branch on 966 enters multiple times because the "api"-array is not initialized or is missing. ie, the anonymous account has no access to api, but filemanager only. the egw_info.user.apps-array is initialized properly (with filemanager) during the first run, but it fails on subsequent calls, causing an exception and returning 401 to the user. the new code handles this situation and allows anonymous users to access the shared files without being asked for username&password by the browser.

Right now, the historylog widget fetches the 50 latest entries from db via nextmatch, with no option to make this number smaller or larger.

To change this, we can just apply our own num_rows (if it is set) when ajax_get_rows is called.

The way to set this is in the widget's content. I have added the appropriate line into Tracking's inline documentation as well.

Usage:

$content['history'] = array(
    'id' => 123,
    'app' => 'calendar',
    'num_rows' => 50, // optional, defaults to 50
    'status-widgets' => array(...),
);

In version 16.1.20160715 when a user creates a calendar event, it fails with the following error in the apache logs (Apache 2.4.23, PHP 7.0.8):

An error happened (EGroupware\Api\Exception\WrongParameter): calendar_bo::resource_info(NULL) parameter must be scalar, referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11 #0 C:\Web\sites\egroupware\calendar\inc\class.calendar_uiforms.inc.php(422): calendar_bo->resource_info(NULL), referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11 #1 C:\Web\sites\egroupware\api\src\loader\deprecated_factory.php(191): calendar_uiforms->process_edit(Array), referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11 #2 C:\Web\sites\egroupware\api\src\Etemplate.php(366): ExecMethod(Array, Array), referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11 #3 [internal function]: EGroupware\Api\Etemplate::ajax_process_content('calendar_egroup...', Array, ''), referer: https://egroupware.sau19.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11 C:\Web\sites\egroupware\api\src\Json\Request.php(179): call_user_func_array(Array, Array), referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11 #5 C:\Web\sites\egroupware\api\src\Json\Request.php(91): EGroupware\Api\Json\Request->handleRequest('EGroupware\Api\...', Array), referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11 #6 C:\Web\sites\egroupware\json.php(119): EGroupware\Api\Json\Request->parseRequest('EGroupware\Api\...', '{"request":{"pa...'), referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11 #7 {main}, referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11

Instance=default, User=egroupware, Request=POST https://egroupware.XXXX.org/json.php?menuaction=EGroupware\Api\Etemplate::ajax_process_content, User-agent=Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0, referer: https://egroupware.XXXX.org/index.php?menuaction=calendar.calendar_uiforms.edit&date=20160719&hour=7&minute=30&owner[]=11

This occurs because the $participant has a value of null during one of the iterations of the foreach loop. This patch simply checks to see if there is a value before executing the code within the loop.

Error message during setup:

2019/03/05 22:12:42 [error] 1276#1276: *36 FastCGI sent in stderr: "PHP message: PHP Warning: Invalid argument supplied for foreach() in /home/asig/dev/egw/egwdev2/html/egw/filemanager/inc/class.filemanager_hooks.inc.php on line 237 PHP message: #1 /home/asig/dev/egw/egwdev2/html/egw/api/src/loader/deprecated_factory.php(179): filemanager_hooks::settings(Array) PHP message: #2 /home/asig/dev/egw/egwdev2/html/egw/setup/inc/class.setup.inc.php(719): ExecMethod('filemanager_hoo...', Array) PHP message: #3 /home/asig/dev/egw/egwdev2/html/egw/setup/inc/class.setup_process.inc.php(463): setup->set_default_preferences('filemanager') PHP message: #4 /home/asig/dev/egw/egwdev2/html/egw/setup/inc/class.setup_process.inc.php(147): setup_process->current(Array, NULL) PHP message: #5 /home/asig/dev/egw/egwdev2/html/egw/setup/index.php(349): setup_process->pass(Array, 'new', NULL, NULL) PHP message: #6 {main}

Hello,

in our organization, inventory requests are handled offline in-person, but we still want to use the resources management egroupware provides to track resource usage and availability.

This patch allows the administrator of an instance to disable invitations to resources by anyone who doesn't have the DIRECT_BOOKING privilege.

Let me know what you think.

I went ahead and put some CSS in the pixelegg.css file Not sure if this is the correct way to proceed, or if I should use LESS in some way. Please advise.

Temporary files under windows are created with a ".tmp" file suffix. Thus the file is not found/readable when trying to provide the download link. This fix additionally enables the check for a potential ".tmp" file suffix so that the export can be used/tested under windows.

Hi actually,

After the first installation, when i restart docker container with EGW_SKIP_INSTALL=true, entrypoint try to execute php /usr/share/egroupware/doc/rpm-build/post_install.php whereas /var/lib/egroupware/header.inc.php exist.

I think the condition is not correct

The duration of a time sheet could be 0, which would cause this conditional statement to be false. This code was responsible for the fact that the sum of the timesheets in the Project Manager app did not match the sum of the timesheets in the Timesheet app.

If someone specified a value for a timesheet linked to a project, e.g. 1 hour, but changed it to 0 after a while. The attribute "pe_used_time" in the table "egw_pm_elements" didn't get updated because of this code.