Right now hydrated entities are cached in \Vin\ShopwareSdk\Repository\Traits\EntityHydrator::hydrateEntity

$cacheKey = $entityRaw['type'] . '-' . $entityRaw['id']; if (array_key_exists($cacheKey, $this->cache)) { return $this->cache[$cacheKey]; }

This should imo get removed without replacement. I'd not expect the SDK to do caching for me. In case I want caching I could easily implement it on my own.

There are some downsides of caching:

• If you search for an entity without associations and later on search for the same entity with association, the "new" hydrated entity is actually the old one without the associations added -> this is what took me quite some time to figure out.

• If you use some web server that doesn't end the PHP progress after the request has been finished this value will be cached forever. Even if the next request comes in after minutes/days/weeks the old value of that entity is still cached. I know common webservers like Apache or Nginx with PHP-FPM start a new process with each request - but new approaches are coming and get more and more popular (Swoole, Roadrunner).

Like I said I don't think caching is necessary (the request to actually get the entity data from Shopware is probably much slower than hydrating the entity) so I'd remove it. In case you think caching should still be present it would be nice to be able to enable/disable it (via Context flag?) or at least to clear it (via method call).

=== Another proposal related: For now I'd like to replace the method hydrateEntity with my own. If hydrateEntity would be public, EntityHydrator would be a class that get's initialized by some factory and injected to the EntityRepository this would be quite easy. But as hydrateEntity is a private trait method inside a Trait which is hardly coupled to EntityRepository this is a bit tricky to do. In general I'd suggest - at least for a library - to avoid Traits and rely on DI instead.

=== PR: https://github.com/vienthuong/shopware-php-sdk/pull/47

Currently, it is not possible to set criteria limit to null.

But this should be possible to allow lists without pagination: https://github.com/shopware/platform/blob/7ed33d9f1ba28888eec93b3ff4f9ba141790a32e/src/Core/Framework/DataAbstractionLayer/Dbal/EntityReader.php#L369

Notice that you're no longer able to determinate this clause if null is an allowed value: https://github.com/vienthuong/shopware-php-sdk/blob/91d0686a8ef22ba56b31fc7c572bdb161a960ce8/src/Data/Criteria.php#L310

Bonus: Currently, it is not possible to pass a custom Criteria instance to any association (It's possible to set dedicated limit rates to each association): https://github.com/vienthuong/shopware-php-sdk/blob/91d0686a8ef22ba56b31fc7c572bdb161a960ce8/src/Data/Criteria.php#L150

Maybe we should change addAssociation(string $path) to addAssociation(string $path ?Criteria $criteria = null) (which creates a new one if not passed to keep BC)?

When I try to get Customers I get the following error: Vin\ShopwareSdk\Data\Struct::addExtension(): Argument #2 ($extension) must be of type Vin\ShopwareSdk\Data\Struct, null given, called When I use other entities such as ProductDefinition, the code works fine. Here is the code I used: `

    $customerRepository = RepositoryFactory::create(CustomerDefinition::ENTITY_NAME);        
    $grantType = new ClientCredentialsGrantType(Configure::read('Shopware.ACCESS_KEY_ID'), Configure::read('Shopware.ACCESS_KEY_SECRET'));
    $adminClient = new AdminAuthenticator($grantType, Configure::read('Shopware.BASE_URL'));
    $accessToken = $adminClient->fetchAccessToken();

    $context = new Context(Configure::read('Shopware.BASE_URL'), $accessToken);        
    
    $criteria = new Criteria();
    $customers = $customerRepository->search($criteria, $context)->getEntities();

`

I am implementing an exception handling regarding missing privileges.

During this, I noticed that EntityRepository::search does throw a ShopwareSearchResponseException, in case Guzzle returns a BadResponseException. I would expect the same from EntityRepository::searchIds, as the exception could also occur there.

In my example the missing privilege was a manufacturer filter for the product.

Cheers!

when eitities have circular references, relationships hydratation enters in an infinite loop...

The fiw was to reserve cache key before hydrating the relationships.

For example : Entity A has association to B Entity B has association to C Entity C has association to B

If a search call is done with a custom definition, there will be a schema call for each entity of the results.

The reason for this is, that the InfoService is instantiated for each entity.

https://github.com/vienthuong/shopware-php-sdk/blob/196268493addaaae52b20356641e622bf107bedd/src/Repository/Traits/EntityHydrator.php#L18-L22

The InfoService has a internal cache, but that cache is non static.

Either the InfoService needs to be a singleton or cached somewhere (RepositoryFactory?) or the cache inside InfoService needs to be static.

Hi,

I am trying to delete relations between products and categories via syncDeleted(). I didn't find any working way to do it other than to change some code in your class and make a pull request today :) You can find more information on this topic in the pull request itself.

Have a nice day!

Dag

Wrong ID mapping on syncDeleted()

Based on this documentation:

https://shopware.stoplight.io/docs/admin-api/ZG9jOjEyMzA4NTUx-bulk-payloads#deleting-relations

it is currently not possible to clear out relations because of the predefined id key mapping here: https://github.com/vienthuong/shopware-php-sdk/blob/78874d2ed9d74d6e4365b423d0284421bb7f1fa8/src/Repository/EntityRepository.php#L157-L159

I guess this might be the correct way it is intended to work:

$repository->syncDeleted([ [ 'productId' => $product->id, 'optionId' => $option->id ] ], $context);

So I removed the use of the $data variable, as seen in my pull request.

When try to read one entry in the system configuration, like that:

$systemConfigRepository = RepositoryFactory::create(SystemConfigDefinition::ENTITY_NAME);
				
$criteria = new Criteria();
$criteria->setLimit(1);
$criteria->addFilter(new EqualsFilter('configurationKey', 'MyFavApiTest.config.receiver'));
				
$result = $systemConfigRepository->search($criteria, $context);

I get an error:

Cannot assign string to property Vin\ShopwareSdk\Data\Entity\SystemConfig\SystemConfigEntity::$configurationValue of type ?array

I changed configurationValue in SystemConfigEntity to data-type of string, and it is working. Is this really an error, or am I doing something wrong?

Setup: Shop: Shopware 6.4.8.1 on PHP 8 App: Symfony 6 on PHP 8

The one that produces the error, is the app.

Thanks for all the good work, so far. It's a pleasure to work with that library.

I am getting error like this

[production.ERROR: {"errors":[{"code":"0","status":"405","title":"Method Not Allowed","detail":"No route found for \u0022GET https:\/\/shopware6.mystore.me\/api\/oauth\/token\u0022: Method Not Allowed (Allow: POST)"}]} {"exception":"[object] (Vin\\ShopwareSdk\\Exception\\AuthorizationFailedException(code: 405)](url)

[previous exception] [object] (GuzzleHttp\\Exception\\ClientException(code: 405): Client error: `POST http://shopware6.mystore.me/api/oauth/token` resulted in a `405 Method Not Allowed` response:
{\"errors\":[{\"code\":\"0\",\"status\":\"405\",\"title\":\"Method Not Allowed\",\"detail\":\"No route found for \\u0022GET https:\\/\\/shop (truncated...)
 at /var/www/tf/shared/vendor/guzzlehttp/guzzle/src/Exception/RequestException.php:113)

Shopware store version: v6.4.6.1

It was working earlier. I don't know this error from shopware after getting upgraded 1.3.2 to 1.3.3 when composer updated. How to solve this issue? Thanks

When using the repositories, I can't have explicit typehints, as the general one is returned for empty results. Would be great, if the correct collection class would be returned for the corresponding repository.

Code:

$criteria1 = new Criteria();
$criteria1->setIds(['ca9f2ea7166c4ff58f42c2e100ca3fd5']);

$criteria2 = new Criteria();
$criteria2->setIds(['0134e8fa91da44c7b5418806d7b95c21']);

/** @var CategoryCollection $categories */
$categories1 = $this->categoryRepository
    ->search($criteria1, $this->context)
    ->getEntities();

$categories2 = $this->categoryRepository
    ->search($criteria2, $this->context)
    ->getEntities();

Result:

Currently Shopware is using GET URLs with the parameters location-id and privileges these parameters are missing in the validation funtion, therefore the calculates hashes are wrong. Following a proposed fix in the file WebhookAuthenticator

public static function authenticateGetRequest(string $shopSecret): bool { $queryString = $_SERVER['QUERY_STRING']; $queries = [];

    parse_str($queryString, $queries);
    
    $shop = new Shop($queries['shop-id'], $queries['shop-url'], $shopSecret);

    $queryString = sprintf(
        'shop-id=%s&shop-url=%s&timestamp=%s&sw-version=%s',
        $shop->getShopId(),
        $shop->getShopUrl(),
        $queries['timestamp'],
        $queries['sw-version'],
    );

    if (array_key_exists('sw-context-language', $queries) && array_key_exists('sw-context-language', $queries)) {
        $queryString = sprintf(
            'shop-id=%s&shop-url=%s&timestamp=%s&sw-version=%s&sw-context-language=%s&sw-user-language=%s',
            $shop->getShopId(),
            $shop->getShopUrl(),
            $queries['timestamp'],
            $queries['sw-version'],
            $queries['sw-context-language'],
            $queries['sw-user-language'],
        );
    }

    if (array_key_exists('location-id', $queries) && array_key_exists('privileges', $queries)) {
        $queryString = sprintf(
            'location-id=%s&privileges=%s',
            $queries['location-id'],
            urlencode($queries['privileges'])
        ) . '&' . $queryString;
    }

    $hmac = \hash_hmac('sha256', htmlspecialchars_decode($queryString), $shopSecret);

    return hash_equals($hmac, $queries['shopware-shop-signature']);
}

I tried to import my products which uses custom entities but without success. Then I tried to get a created product with my custom association also without success. So my question is does this sdk support custom extensions at all? I didn't find any documentation about that topic. Thanks

What is the common way to iterate through many entities, for example a thousand products or more?

Now i do it in this way, but it feels not good, what is your solution?

    private function getProducts(): \Generator
    {
        $criteria = new Criteria();
        $productRepository = RepositoryFactory::create(ProductDefinition::ENTITY_NAME);

        do {
            $result = $productRepository->search($criteria, $this->getContext());

            /** @var ProductEntity $product */
            foreach ($result->getEntities() as $product) {
                yield $product;
            }
            $criteria->setPage($criteria->getPage() + 1);
        } while (($result->count()) === $criteria->getLimit());
    }

if i remove the limit with $criteria->setLimit(null); i got the Allowed memory size error

We've released the SDK for a while and as Shopware core is growing really fast as well, the SDK might get a bit out of date APIs, or lack features, using deprecated APIs, etc...

So with this thread, I want to gather the ideas/solutions from the community or even improve PR to make the SDK better. Any comments/suggestions are welcomed and highly appreciated 🤝

For bug issues, please create a new one so I can keep the track of them :)