• added a slugify and titlecase function:
  • Jack, Jill & Clémence LTD => jack-jill-clemence-ltd
  • Jack, Jill & Clémence LTD => JackJillClemenceLtd
• use better placeholders so that composer doesn't give the error "./composer.json" does not match the expected JSON schema" (email, vendor_slug, package_slug)
• default for Author_username now derived from github username

This PR will fix the renaming feature in Windows systems. Windows is using this convention in file paths : D:\testing\file.php while others are using var/www/htdocs/file.php So by fixing the feature, files now will be renamed when executing the configure script.

Attention: This is the companion PR to the PR "hasMiddleware feature added" in spatie/laravel-package-tools

This PR implements the default SkeletonMiddleware and the filename replacements in configure.php

Feature "hasMiddleware" (See PR in laravel-package-tools)

"This PR adds the feature hasMiddleware to the laravel-package-tools. If added, the middleware automatically runs on each request. This feature allows to apply a middleware globally or only assign it to a specific middleware group."

Example: ->hasMiddleware(MyMiddleware::class, 'api')

For a full documentation please see the laravel-package-tools PR.

Hi spatie team

First of all thank you for this great package 👏

This package does not work on windows due to missing grep. This pull adresses that using windows available commands.

Kind regards Carlos

I've updated the shell script to automatically replace the placeholder values such as "skeleton", "spatie". I've used the generated suggested ClassName ( which was already there ) for replacing Skeleton class name. and added a user input to get the vendor name and replaced it with "spatie". moreover, I 've renamed the files according to the package name. Hope this will save some time.

Using a word "Laravel" for your package name is a terrible idea. This PR will prevent it from happening.

If you create a package and it's name containing a word "laravel", then publishing view files by running php artisan vendor:publish will cause you a problem.

For example, imagine you created a package named : Laravel-Viewtester. Then package-skeleton-laravel will generate something like LaravelViewtester/src/LaravelViewtesterServiceProvider.php.

Inside of this generated file will be like this:

class /LaravelViewtesterServiceProvider extends PackageServiceProvider
{
    public function configurePackage(Package $package): void
    {
        /*
         * This class is a Package Service Provider
         *
         * More info: https://github.com/spatie/laravel-package-tools
         */
        $package
            ->name('laravel-viewtester')
            ->hasConfigFile()
            ->hasViews();
    }
}

Now your package is ready and you install this package to new Laravel project by composer for testing. Everything seems OK, then you run php artisan vendor:publish. Your terminal shows that all those providers and tags. But instead of Tag: laravel-viewtester-views you see Tag: viewtester-views.

How come?

Because package-skelton-laravel uses laravel-package-tools, it publishes those view files by using these lines of code.

$this->publishes([
    $this->package->basePath('/../resources/views') => base_path("resources/views/vendor/{$this->package->shortName()}"),
], "{$this->package->shortName()}-views");

Now shortName() will remove 'laravel-' prefix from Package name.

public function shortName(): string
{
    return Str::after($this->name, 'laravel-');
}

Although you could publish your package view files, Laravel is not going to use it. Because Laravel tries to search resources/views/vendor/laravel-viewtester/*.blade.php first, but your published views are located in resources/views/vendor/viewtester/*.blade.php instead. So Laravel is not going to find them.

How this PR will prevent it?

When you run php ./configure.php and if you use "laravel" in your package name, this PR warns users try not to use "laravel" for your package name.

Hope this will prevent these mistakes happening again.

I saw a previous PR (https://github.com/spatie/package-skeleton-laravel/pull/153) about generating middleware with the skeleton package, and it has an unresolved conflict.

So, I tried to create a new one with the same logic, and hope this one get merged :)

There are some missing parts on configuration.php file. I think it's related to #146, the PHP configuration script added instead of the bash script does not do some of the things that the bash script does.

The problems that I encounter:

• does not rename migration file
• does not rename config file
• does not change skeleton in all files, (it only changes Skeleton but code includes both Skeleton and skeleton)

I think I fixed all of them but I was using this package first time. So I'm not sure whether the missing parts and all use cases are covered. It would be great if you could check it out, thanks!

This pull request adds a new "Vendor namespace" question to the configuration script, allowing you to customise the vendor namespace.

This is useful for scenarios where the vendor name for the package differs, e.g. I use ryangjchandler for the vendor name but RyanChandler for the namespace.

Before Testbench 6.19

You need to remember to do the following:

./vendor/bin/testbench package:discover
./vendor/bin/testbench package:test --parallel

With Testbench 6.19

No longer need to run package:discover, package:test will always be available when using testbench and no longer accidentally register when using artisan from a Laravel application.

./vendor/bin/testbench package:test --parallel

The \s doesn't work for some implementations of sed.

On mac, using \s removes 's' from the class name and keep spaces.

Changing to the POSIX compliant value [[:space:]] fixes it for all.

Fixes #32 , tested on mac (had issue) and ubuntu (didn't have issue)

Bumps aglipanci/laravel-pint-action from 1.0.0 to 2.1.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.