I was trying this bundle, without success.

Upon debugging i figured the profiles are filtered out based on kernel boot time (which theoretically makes sense :))

First run:

^ "Profile: 2022-07-12 12:25:36"
^ "Kernel:  2022-07-12 12:26:21"

Second run:

^ "Profile: 2022-07-12 12:26:22"
^ "Kernel:  2022-07-12 12:26:28"
^ "Profile: 2022-07-12 12:25:36"
^ "Kernel:  2022-07-12 12:26:28"

Im not entirely sure why profiles are stored first :thinking: nor do i have another solution, but perhaps food for thought.

This patch fixes an error when the symfony router is overridden:

Symfony\Component\Debug\Exception\FatalThrowableError^ {#8
  -originalClassName: "TypeError"
  #message: "Sourceability\ConsoleToolbarBundle\Console\ProfilerToolbarRenderer::__construct(): Argument #1 ($router) must be of type Symfony\Component\Routing\Router, EmmaCare\Shared\Service\Router given, called in /tmp/symfony/chat/local/Container1eAVnW7/getSourceability_ConsoleToolbar_Console_ProfilerToolbarRendererService.php on line 9"
  #code: 0
  #file: "./vendor/sourceability/console-toolbar-bundle/src/Console/ProfilerToolbarRenderer.php"
  #line: 71
  #severity: E_RECOVERABLE_ERROR
  trace: {
    ./vendor/sourceability/console-toolbar-bundle/src/Console/ProfilerToolbarRenderer.php:71 { …}
    /tmp/symfony/chat/local/Container1eAVnW7/getSourceability_ConsoleToolbar_Console_ProfilerToolbarRendererService.php:9 {
      require^
      › 
      › return $this->services['sourceability.console_toolbar.console.profiler_toolbar_renderer'] = new \Sourceability\ConsoleToolbarBundle\Console\ProfilerToolbarRenderer(($this->services['router'] ?? $this->getRouterService()), ($this->services['profiler'] ?? $this->getProfilerService()), ($this->services['twig'] ?? $this->getTwigService()), $this->parameters['data_collector.templates'], [0 => 'config', 1 => 'form', 2 => 'validator', 3 => 'logger'], 30);
      › 
      arguments: {
        $router: EmmaCare\Shared\Service\Router {#8581 …}
        $profiler: Symfony\Component\HttpKernel\Profiler\Profiler {#9514 …}
        $twig: Twig\Environment {#10540 …}
        $templates: array:23 [ …23]
        $hiddenPanels: array:4 [ …4]
        $maxColumnWidth: 30
      }
    }
    /tmp/symfony/chat/local/Container1eAVnW7/srcApp_KernelLocalDebugContainer.php:192 { …}
    /tmp/symfony/chat/local/Container1eAVnW7/getSourceability_ConsoleToolbar_EventListener_ConsoleToolbarListenerService.php:9 { …}
    /tmp/symfony/chat/local/Container1eAVnW7/srcApp_KernelLocalDebugContainer.php:192 { …}
    /tmp/symfony/chat/local/Container1eAVnW7/srcApp_KernelLocalDebugContainer.php:709 { …}
    ./vendor/symfony/event-dispatcher/EventDispatcher.php:279 { …}
    ./vendor/symfony/event-dispatcher/EventDispatcher.php:90 { …}
    ./vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php:334 { …}
    ./vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php:162 { …}
    ./vendor/symfony/console/Application.php:1042 { …}
    ./vendor/symfony/framework-bundle/Console/Application.php:97 { …}
    ./vendor/symfony/console/Application.php:273 { …}
    ./vendor/symfony/framework-bundle/Console/Application.php:83 { …}
    ./vendor/symfony/console/Application.php:149 { …}
    ./bin/console:39 { …}
  }
}

After upgrading to 0.1.4 I am getting an error when running console command with --toolbar option:

In ProfilerToolbarRenderer.php line 148:
                                                               
  [Symfony\Component\Debug\Exception\FatalThrowableError (1)]  
  assert($fillCount > 0)                                       
                                                               

Exception trace:
  at /app/vendor/sourceability/console-toolbar-bundle/src/Console/ProfilerToolbarRenderer.php:148
 assert() at /app/vendor/sourceability/console-toolbar-bundle/src/Console/ProfilerToolbarRenderer.php:148
 Sourceability\ConsoleToolbarBundle\Console\ProfilerToolbarRenderer->renderRow() at /app/vendor/sourceability/console-toolbar-bundle/src/Console/ProfilerToolbarRenderer.php:121
 Sourceability\ConsoleToolbarBundle\Console\ProfilerToolbarRenderer->render() at /app/vendor/sourceability/console-toolbar-bundle/src/EventListener/ConsoleToolbarListener.php:107
 Sourceability\ConsoleToolbarBundle\EventListener\ConsoleToolbarListener->onTerminate() at /app/vendor/symfony/event-dispatcher/Debug/WrappedListener.php:126
 Symfony\Component\EventDispatcher\Debug\WrappedListener->__invoke() at /app/vendor/symfony/event-dispatcher/EventDispatcher.php:264
 Symfony\Component\EventDispatcher\EventDispatcher->doDispatch() at /app/vendor/symfony/event-dispatcher/EventDispatcher.php:239
 Symfony\Component\EventDispatcher\EventDispatcher->callListeners() at /app/vendor/symfony/event-dispatcher/EventDispatcher.php:73
 Symfony\Component\EventDispatcher\EventDispatcher->dispatch() at /app/vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php:168
 Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->dispatch() at /app/vendor/symfony/console/Application.php:1042
 Symfony\Component\Console\Application->doRunCommand() at /app/vendor/symfony/framework-bundle/Console/Application.php:97
 Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at /app/vendor/symfony/console/Application.php:273
 Symfony\Component\Console\Application->doRun() at /app/vendor/symfony/framework-bundle/Console/Application.php:83
 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /app/vendor/symfony/console/Application.php:149
 Symfony\Component\Console\Application->run() at /app/bin/console:39

Symfony 6 requires the package and version parameters to be set when calling setDeprecated. This updates the file to name both this bundle and the earliest version where the deprecation was introduced.

Symfony 5.4 crashing when running behat tests because the full_stack variable doesn't exist and get passed to toolbar.html.twig

See the addition of the variable in the web-profile-bundle

The if call in the template fails

{% if full_stack %}

Note, the IDE didn't want to recognize FullStack::class as an existing class, so I went with Symfony\Bundle\FullStack (which is the class's full path) instead.

Testing locally, this fix allowed my behat tests to run again

Here's a rough idea:

When behat drives/runs a browser like chrome, it could be interesting to have screenshots/previews printed in the terminal.

Or links to "page snapshots" or something.

@adrienbrault first of all amazing work!!!

I have a little doubt, is there any way to make the dump() go out through the profiler?

Thank you so much!

<?php

namespace App\Command;

use Sourceability\Instrumentation\Profiler\ProfilerInterface;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class PagerFantaCommand extends Command
{

    /**
     * @var ProfilerInterface
     */
    private $profiler;

    public function __construct(ProfilerInterface $profiler)
    {
        parent::__construct();

        $this->profiler = $profiler;
    }

    protected function configure()
    {

        $this
            ->setName('app:pager:fanta');

    }

    protected function execute(InputInterface $input, OutputInterface $output): int
    {

        $this->profiler->start('pagerFanta');

        dump('hi world!');

        $this->profiler->stop();

        return 0;
    }

}