Hi there,

I'm using your very wonderful code but I noticed that I run into this problem: Call to a member function get_uri() on a non-object in simplepie/library/SimplePie/Misc.php on line 83

I really don't have an idea why this is happening.

Kindly guide me how to fix this one.

Thanks!

Hi all 👋

This PR increases the required PHP version to 7.2 or newer. I propose this PR for SimplePie 1.8 (see Roadmap in #731).

Increasing the PHP version to 7.2 will give us some new features:

• Return type declarations
• Strict typing (declare(strict_types=1);)
• Anonymous classes
• Nullable types
• Void functions
• Symmetric array destructuring (already used in this PR)
• Class constant visibility (already used in this PR)
• Abstract method overriding
• Parameter type widening

It will allow us to support PSR-18 HTTP client (see #520)

Based on the download numbers from packagist.org (see below) I would say that it is save to increase the PHP version to 7.2. But I would also like to hear feedback from projects like WordPress (ping @rmccue) and FressRSS (ping @Alkarex).

Downloads for all SimplePie versions

Over 96% of all downloads are on PHP 7.2 or newer.

Downloads for SimplePie version 1.6

Looking only at SimplePie 1.6 over 98% of all downloads are on PHP 7.2 or newer.

Changed log

• Nowadays, it should let the version PHP 7+ pass the tests during doing Travis CI build.
• In the PHP 7.x, the PHPUnit_Framework_Error_Notice class is not found. To be compatiable with the PHP 5.x, I use the class_alias to let PHPUnit_Framework_Error_Notice alias the PHPUnit\Framework\Error\Notice.
• Consider the old tests and I sperate two different phpunit.xml.dist setting files. It can see more details about the composer.json and .travis.yml.
• Fix the assertions when executing Travis CI build. In some test cases, the port number in url can identify the difference. I notice that the substr function is diffreent in PHP 5.x and PHP 7.x. This link can see more details about the substr difference in different PHP version. In PHP 7+, If the start character length is equal to string length, it will return empty string. But in PHP 5.x it will return boolean(false). It happens on line 916 of IRI.php.

I'm using PHP 5.3.2-1 and all Facebook Notes RSS feeds causes following error:

"This XML document is invalid, likely due to invalid characters. XML error: Not well-formed (invalid token) at line 2, column 1" (Retrieved it using error() function)

Here is one link to feed to test against.

This cannot be replicated with your demo, it is probably related to PHP version. But I used your normal demo/index.php to replicate this with latest Debian PHP.

Hi,

the bug below happens because library/SimplePie/Cache/DB.php should be included first then library/SimplePie/Cache/MySQL.php in SimplePie.compiled.php

PHP Fatal error: Class 'SimplePie_Cache_DB' not found in /home/metal/debian/simplepie/SimplePie.compiled.php on line 11857 PHP Stack trace: PHP 1. {main}() /root/simplepie/test-1.3.0.php:0 PHP 2. include_once() /root/simplepie/test-1.3.0.php:2

Hi! I use simplepie for get rss. I create a file (test1.php) in simplepie script in the path (simplepie/demo) with this code:

header('Content-type:text/html; charset=utf-8');

include_once('../autoloader.php');
include_once('../idn/idna_convert.class.php');

$feed = new SimplePie();
$feed->set_feed_url('http://pop-music.ir/feed');
$feed->force_feed(true);
$feed->set_input_encoding('UTF-8');
$feed->set_output_encoding('UTF-8');
$feed->init();
$feed->handle_content_type();
echo $feed->get_title();

if ($feed->error())
{
    echo '' . "\r\n";

        // ... and display it.
        echo '<p>' . htmlspecialchars($feed->error()) . "</p>\r\n";
    echo ' . "\r\n";
}
?>

But the script gives the following error:

The data could not be converted to UTF-8. You MUST have either the iconv or mbstring extension installed. Upgrading to PHP 5.x (which includes iconv) is highly recommended.

My host is upgraded for PHP 5.2.17.

When I check url rss like this http://pop-music.ir/feed on my script, I get error but when check this url in demo simplepie view demo this url I can view rss!!!!

Please Help me:(

im processing feeds with simple pie, in wordpress.

and im keeping a record of each feed i process in a custom table, with a token with $item->get_id();

but when i run a "group by token" sql query, i get multiple rows with the same token,.... which shows get_id() is not giving me unique identifiers as it should.

please advise

Is PHP 7 support realistic? http://php.net/supported-versions.php

There is currently 4 errors, 3 of them most likely due to the same port-number bug... https://travis-ci.org/simplepie/simplepie

The coding standards used are way outdated, and with files counting 3.000+ lines, isn't making the job of fixing it easier either. Normally I'm trying to contribute instead of posting issues, but that's not realistic in this case... sorry!

2.0: Start the refactoring process, update the standards, replace old bunks of code with external maintained repositories, less code, fewer bugs, better support. Then it would be easier for everyone, also it will making sure this repository doesn't get out of date! Because who are using php 5.3 today??

get_content() bug:

If the original feed contains <br/>, it's converted into <br>. This would be fine (albeit unnecessary) if the intended output were HTML, but since the the demo page is supposed to be XHTML that's somewhat strange, especially considering the source which is well-formed XML.

html_entity_decode($item->get_title(), ENT_QUOTES, 'UTF-8');

This isn't actually an issue with get_title(), but because html_entity_decode is applied in the demo code this results in things like & being displayed as &, thus breaking properly served XHTML & XML, but it's not valid HTML either.

Since the only real issue I ran into was this turning of <br/> into <br> I fixed it with the following little dirty class. When I first encountered the bug I falsely assumed it was intentional and thus wrote it to affect all self-closed tags, but it looks like only <br/> is victimized.

class SimplePie_XHTML extends SimplePie {
    function fix_xhtml ($html) {
        $xhtml;
        //$self_closing = array ('br', 'hr', 'input', 'img');
        $self_closing = array ('br'); ///only those not handled correctly by SimplePie go in here
        for ($i = 0; $i < count($self_closing); $i++) {
            $xhtml = preg_replace ("/<".$self_closing[$i]."(.*)>/sU","<".$self_closing[$i]."\\1/>",$html);
        }
        return $xhtml;
    }
}

This PR changes the code style in all classes and tests to PSR-12. As discussed with @jtojnar in https://github.com/simplepie/simplepie/pull/734#issuecomment-1132595248 I think that after the huge changes from #722 the timing is ideal.

With 7.4.0RC3

There were 8 errors:

1) OldTest::testOld with data set #682 (SimplePie_First_Item_Permalink_Test_Atom_03_Enclosure Object (...))
Trying to access array offset on value of type null

/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:961
/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:936
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/functions.php:328
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/compat_test_harness.php:40
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests.php:82

2) OldTest::testOld with data set #684 (SimplePie_First_Item_Permalink_Test_Atom_10_Enclosure Object (...))
Trying to access array offset on value of type null

/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:961
/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:936
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/functions.php:328
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/compat_test_harness.php:40
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests.php:82

3) OldTest::testOld with data set #688 (SimplePie_First_Item_Permalink_Test_Bug_10_Test_2 Object (...))
Trying to access array offset on value of type null

/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:961
/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:936
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/functions.php:328
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/compat_test_harness.php:40
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests.php:82

4) OldTest::testOld with data set #689 (SimplePie_First_Item_Permalink_Test_Bug_10_Test_3 Object (...))
Trying to access array offset on value of type null

/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:961
/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:936
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/functions.php:328
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/compat_test_harness.php:40
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests.php:82

5) OldTest::testOld with data set #690 (SimplePie_First_Item_Permalink_Test_Bug_156_Test_0 Object (...))
Trying to access array offset on value of type null

/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:961
/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:936
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/functions.php:328
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/compat_test_harness.php:40
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests.php:82

6) OldTest::testOld with data set #702 (SimplePie_First_Item_Permalink_Test_RSS_091_Userland_Atom_03_Link_Enclosure Object (...))
Trying to access array offset on value of type null

/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:961
/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:936
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/functions.php:328
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/compat_test_harness.php:40
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests.php:82

7) OldTest::testOld with data set #704 (SimplePie_First_Item_Permalink_Test_RSS_091_Userland_Atom_10_Link_Enclosure Object (...))
Trying to access array offset on value of type null

/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:961
/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:936
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/functions.php:328
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/compat_test_harness.php:40
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests.php:82

8) OldTest::testOld with data set #712 (SimplePie_First_Item_Permalink_Test_RSS_20_Enclosure Object (...))
Trying to access array offset on value of type null

/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:961
/dev/shm/BUILDROOT/php-simplepie-1.5.2-1.fc29.remi.x86_64/usr/share/php/php-simplepie/SimplePie/Item.php:936
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/functions.php:328
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests/compat_test_harness.php:40
/dev/shm/BUILD/simplepie-173663382a9346acd53df60c7ffb20689c9cf1f6/tests/oldtests.php:82

ERRORS!
Tests: 1313, Assertions: 1413, Errors: 8.

Add missing sanitize and absolute_url on thumbnail URL.

SimplePie normally sanitizes all URLs, but the thumbnail URL was not processed.

Related to https://github.com/simplepie/simplepie/pull/768

Downstream PR https://github.com/FreshRSS/FreshRSS/pull/4944

SimplePie only returned the first enclosure when using the RSS 2.0 syntax for enclosures, instead of returning them all.

Please merge https://github.com/simplepie/simplepie/pull/768 first.

Downtream PR: https://github.com/FreshRSS/FreshRSS/pull/4944

Having an urldecode returns some potentially invalid URLs for enclosures, while SimplePie does not do that for other returned URLs.

Seems to be a similar error than https://github.com/simplepie/simplepie/commit/efb1d8e34c39276fb88fff0dcff01c673bec7e18

This line was introduced in https://github.com/simplepie/simplepie/commit/4bbd7eacfb6940d06899fa74a08754389ddd98de

Downstream PR https://github.com/FreshRSS/FreshRSS/pull/4944

P.S. There are a few other bugs related to enclosure links, and I will try to address some of them in distinct PRs.

As discussed with @jtojnar I finalized #737 for using class-strings instead of strings in Registry class. #737 can be closed.

It also create legacy replacements to provide BC. In future it should also possible to use an interface as $type and provide an implementing class as $class.

In this PR we can prepare everything for the release of SimplePie 1.8.0

Check list:

• [x] bump version in constant SimplePie\SimplePie::VERSION.
• [x] Add entries for all changes in CHANGLOG.md.
• [x] Add missing authors and issues in CHANGLOG.md if necessary.
• [x] Fix code style by running bin/php-cs-fixer fix.

After #756 is merged, we should do the following:

• [ ] Change Sam’s name: https://github.com/simplepie/simplepie/issues/543#issuecomment-659126604
• [ ] Look at the old reference docs and check if there is something useful we should preserve into PHPDoc.
• [ ] Drop the old reference docs.
• [ ] Clean up the plug-in list (maybe just keep a single page with list of links and brief description)
• [ ] Figure out if the IRC channel still exists after the Freenode fiasco. Maybe create a new room at Libera or Matrix.
• [ ] Fix wiki syntax in docs/content/wiki/misc/release_notes/simplepie_beta_3.html