Hey Shea,

First off, sweet module - makes administration functionality a lot easier to implement and test over multiple users. Would you be able to tag a release for the latest master branch, the other tags are a bit stale.

It would be great if UserSwitcher could be placed inside BetterNavigator which resides on the top right of the page.

I don't know if it's currently possible to add fields or HTML to BetterNavigator, maybe it'd need to be changed to get this working.

See https://github.com/jonom/silverstripe-betternavigator

fix(UserSwitcher): Stop most of the logic from using entwine.

This fixes https://github.com/sheadawson/silverstripe-userswitcher/issues/11.

I honestly don't know what entwine is doing, but it seemed to be buggy when the $.get function block was in the scope of the $.entwine() function.

In any case, this should retain the expected behaviour, but not bug things out.

fix(this._super): Add this._super calls to avoid weird JS breaking behaviour.

I didn't hit any specific issues recently, but I recall trying to use this module on a previous project and it caused things to be broken, so my assumption is that it's the missing this._super() calls.

When running dev/build on 3.1.15 and changing something on Member i get an error like:

[User Error] Couldn't run query: SELECT DISTINCT "Member"."ClassName", .... FROM "Member" WHERE ("Member"."ID" = 123) ORDER BY "Member"."Surname" ASC, "Member"."FirstName" ASC LIMIT 1 Unknown column 'Member.Foo' in 'field list'

Disabling userswitcher by putting a _manifest_exclude file in fixes this problem by now but isn't that comfortable...

fix(dev/build): Ignore onAfterInit logic inside dev/build, Move various copy-pastes of "Permission::check('ADMIN') || Session::get('UserSwitcher')" logic into one service class UserSwitcher.

fix(jQuery): Fixes case where you Requirements::block() jquery.js in your Page::init(), but it's not respected due to UserSwitcherControllerExtension::onAfterInit providing jquery.js on-the-fly via jquery.ondemand.

This is what would have been causing quirks on the frontend for most users I'd say. They were rolling their own jQuery and jquery.ondemand was hosing everything.

I believe it has something to do with the $('body').entwine() functionality, but it seems to be stopping behaviour from executing when I dynamically AJAX elements in on the frontend.

To avoid quirks causing timesinks, I think I'll avoid this module until the entwine() functions don't mess with core functionality in unpredictable/odd ways.

Hello!

I'm helpful robot. I noticed you don't have a Scrutinizer config file. This one adds many code quality checks. If you are unsure of how to connect your repository to Scrutinizer, read the guide I wrote for you humans.

Have a nice day! [brrrrb, click]

Hello!

I'm helpful robot. I noticed you don't have a git attributes file. You were forcing my brother and sister robots to download files you were never going to use anyway. I hope you feel better ignoring those files...

Have a nice day! [pirrrrrlk]