I just wanted to create this issue here for visibility for anyone who might have the same issue. Due to an issue in the nikic/PHP-Parser package if you use self-executing anonymous functions the tests break and throw an error.

Full details can be seen here: nikic/PHP-Parser#316

This set of commits fixes the issue of #15 that I recently reported.

All tests were passing still on my end and this now allows me to run with out commenting out GREs. However once I started using ./vendor/bin/phpunit I got all sorts of errors in tests. I made an attempt at fixing most of them but I wasn't familiar enough with the packing and how to properly fix the remaining test that has issues.

I tried the v0.8.0 on one of my project and I got the following error

Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/www/vendor/rskuipers/php-assumptions/src/PhpAssumptions/Cli.php on line 138

I ran the project in a docker container that own a PHP 8.1 version.

To fix it, the following line : https://github.com/rskuipers/php-assumptions/blob/master/src/PhpAssumptions/Cli.php#L138

could definitly be replaced by

if ($list !== '') {

as the only purpose of the usage of strlen here is to check if the string is not empty.

EDIT: the only usage I found is actually here: https://github.com/rskuipers/php-assumptions/blob/10f82ca2a268d6624553d2de4659ed6451d9ac60/src/PhpAssumptions/Cli.php#L105

After a quick look at \League\CLImate\Argument\Manager::get method, I found out it can return null. As the argument of getPathsFromList is supposed to be a string (read from PHPDoc + inferred from usage in the method), I think a cast should be executed while passing the argument:

$excludes = $this->getPathsFromList((string)$this->cli->arguments->get('exclude'));

Indeed, the return type of \League\CLImate\Argument\Manager::get is string|int|float|bool|null, all of them castable to string.

Hey 👋

PHP 7.3 is released 🎉. I happened to stumble upon this repo and thought it would be a quick nifty addition.

Let me know if you need any changes.

Add an option to allow some files (or directories) to be excluded from the analyze.

I encounter a case where I wanted to check a project root path, but I get a lots of errors from the vendor directory.

Composer refuses to install stable version of PHP Assumptions because my project requires nikic/php-parser ^3.0.

I can see that it is fixed in a9ca134e598d9e361c713332e1aa62400fdadf97, and I was able to install rskuipers/php-assumptions:dev-master, but I would prefer to use a stable version.

Could you please release a new stable version?

This PR introduces CLImate to the project, this is in preparation for new XmlOutput to give the option to switch format with CLI argument.

CLImate also offers nice output so the PrettyOutput has been updated to output a table instead.

Closes #7

PhpSpec doesn't offer much that PHPUnit with Prophecy can't provide. For the sake of using one tool for our tests, we should remove PhpSpec and convert any existing tests over to PHPUnit.

The example in documentation is a bit confusing as it's out of context. It wouldn't make immediate sense to those using mostly strict type hinting.

It needs to have the user class coming from something that could return another class type to make it absolutely clear.

A simpler way to describe it is instead of using assumption / assertion is to check for that it actually needs to be, that makes it clearly what's happening and if for example type hinting elsewhere already provides that guarantee.

Suppose I have two DateTimeImmutable objects, let's say $a and $b, and I want to check whether they are referring to the same point in time.

You can't user $a === $b for this, because that would always return false. But if you use $a == $b, phpa will complain.

Any suggestions about how to work around this problem?

I'm running Assumptions with the following command on windows 10:

tool-assumptions --exclude=./vendor ./

And i get this error:

PHP Fatal error: Uncaught PhpParser\Error: Syntax error, unexpected '{', expecting T_STRING on line 2 in C:\Users\vheidemann\projects\ci-tool-installer\assumptions\vendor\nikic\php-parser\lib\PhpParser\ParserAbstract.php:293

Stack trace:

#0 C:\Users\vheidemann\projects\ci-tool-installer\assumptions\vendor\nikic\php-parser\lib\PhpParser\Parser\Multiple.php(50): PhpParser\ParserAbstract->parse('<?php\nclass {CL...', Object(PhpParser\ErrorHandler\Throwing)) #1 C:\Users\vheidemann\projects\ci-tool-installer\assumptions\vendor\nikic\php-parser\lib\PhpParser\Parser\Multiple.php(31): PhpParser\Parser\Multiple->tryParse(Object(PhpParser\Parser\Php7), Object(PhpParser\ErrorHandler\Throwing), '<?php\nclass {CL...') #2 C:\Users\vheidemann\projects\ci-tool-installer\assumptions\src\PhpAssumptions\Analyser.php(71): PhpParser\Parser\Multiple->parse('<?php\nclass {CL...') #3 C:\Users\vheidemann\projects\ci-tool-installer\assumptions\src\PhpAssumptions\Cli.php(120): PhpAssumptions\Analyser->analyse(Array) #4 C:\Users\vheidemann\projects\ci-t in C:\Users\vheidemann\projects\ci-tool-installer\assumptions\vendor\nikic\php-parser\lib\PhpParser\ParserAbstract.php on line 293

Any ideas what to do?

This would be reported:

<?php

if ( 'cli' !== PHP_SAPI ) {  // THIS LINE
  throw new \Exception('only from CLI');
}

echo 'hi';

We check if the current system state is something that we can work with. In general we reject everything except the one working thing which is an assertion IMHO.

This wouldn't be reported:

<?php

if ( 'cli' === PHP_SAPI ) {
  echo 'hi';
} else {
  throw new \Exception('CLI!');
}

Which makes the code unreadable if you think of 4-5 paths which are then nested damn deep. Also PHPMD may nag about the "else" and the linux kernel standards says

Now, some people will claim that having 8-character indentations makes the code move too far to the right, and makes it hard to read on a 80-character terminal screen. The answer to that is that if you need more than 3 levels of indentation, you’re screwed anyway, and should fix your program.

So please tell me how we can avoid the first expression to be marked as an "assumption".

Hi,

I am trying out this tool and when running it, I get this error, any ideas what I could do about this?

Call to undefined function PhpParser\canonicalize() in /php_assumptions/vendor/nikic/php-parser/test/PhpParser/CodeTestAbstract.php on line 17