For anyone who wants to have quick fix before merge.

# composer.json

{
    "require": {
        // ...
        "outl1ne/nova-media-hub": "dev-main",
    },
    "repositories": {
        // ...
        "nova-media-hub": {
            "type": "vcs",
            "url": "https://github.com/godkinmo/nova-media-hub.git"
        }
    }
}

Then

composer require outl1ne/nova-media-hub:dev-main

Hello, I'm not sure if this is intended or not. But there is no way to upload files directly from the resource. I'm using version 1.4.1 and this is what I see (https://imgur.com/a/VSpBP82) Can anyone confirm if this is intended ?

can't install it , i got the follwing error when run composer require outl1ne/nova-media-hub

Your requirements could not be resolved to an installable set of packages.

Problem 1 - outl1ne/nova-media-hub[1.0.0, ..., 1.0.2] require outl1ne/nova-translatable 2.0.4 -> found outl1ne/nova-translatable[2.0.4] but the package is fixed to 2.0.6 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command. - outl1ne/nova-media-hub[1.0.3, ..., 1.0.5] require spatie/image ^2.2 -> found spatie/image[2.2.0, ..., 2.2.4] but the package is fixed to 1.10.6 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command. - Root composer.json requires outl1ne/nova-media-hub ^1.0 -> satisfiable by outl1ne/nova-media-hub[1.0.0, ..., 1.0.5].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions. You can also try re-running composer require with an explicit version constraint, e.g. "composer require outl1ne/nova-media-hub:*" to figure out if any version is installable, or "composer require outl1ne/nova-media-hub:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

Theres is a problem when media is created from a remote source. The last character of the original file name is trimmed.

To reproduce the issue run in a console:

php artisan tinker

and then enter:

\Outl1ne\NovaMediaHub\MediaHub::storeMediaFromUrl('https://picsum.photos/1920/1080.jpg', 'default');

As a result a new file with wrong filename (108.jpg instead of 1080.jpg) is saved:

That's because files saved in /tmp directory don't have an extension.

Hi,

I like this project you've built, but before I can implement it I have a question which I could not find any answers in the documentation or code:

Is there any way to perform validation on the files being uploaded? I would like to limit the filetypes being uploaded, add our own custom file rules, perform virus scan on uploads etc.

As example someone now can easily upload a test.php with the following script:

<?php

echo phpinfo();

after uploading and the uploading folder is set to public, anyone can go to the url of that file and get all php info of the server.

If it doesn't exist yet, it would be awesome to add in the config/nova-media-hub.php something like the following:

return [
    //...

    'file_validation' => [
        '*' => [ // any collection
            'file',
            'max:5000',
            'mimes:doc,xls,jpg,png,svg,pdf'
            MyCustomRule::class,
            // array of validation rules like you would normally have in laravel
        ],
        'images' => [ // validation just for this collection
             'image'
        ]
    ]
];

It would be better if "upper" is replaced by "lower" and unicode search problem will be resolved.

For example, if Text Title (or any field in data column) is "ტესტ", search doesn't work.

We noticed that filenames for uploaded images are being double-url-encoded - for instance File-(2).jpg was decoded as File-%25282%2529.jpg instead of File-%282%29.jpg.

This is due to the ->url() method of Storage already URL-encoding.

This PR removes the double encoding, producing working URLs again.

Hi, thanks for the great package !

I'm using your MediaHub::fileHandler to seed a new database from existing files.

MediaHub::fileHandler()            
    ->withFile($questions_audios->path($question['id_audio_fr'] . '.mp3'))
    ->withCollection('question_audio')
    ->save();

But the save() method deletes the original files by default: $this->filesystem->copyFileToMediaLibrary($this->pathToFile, $media, $this->fileName, Filesystem::TYPE_ORIGINAL, **true**);

I'm wondering if this is the wanted behavior and if it should not be false by default ? I didn't lose any files but can imagine someone getting bit by this particular situation.

If this is the desired behavior on your side, should it be possible to modify it slightly to delete but on demand ? Like maybe :

protected string $removeOnSave = false;

public function removeOnSave(bool $removeOnSave)
{
    $this->removeOnSave = $removeOnSave;
    return $this;
}

$this->filesystem->copyFileToMediaLibrary($this->pathToFile, $media, $this->fileName, Filesystem::TYPE_ORIGINAL, $this->removeOnSave);

Then we could use it like this:

MediaHub::fileHandler()            
    ->withFile($questions_audios->path($question['id_audio_fr'] . '.mp3'))
    ->withCollection('question_audio')
    **->removeOnSave(true)**
    ->save();

Cheers !

Working in the field of digital publishing, we needed to adapt the code of your excellent extension with internal needs.

I have tried to keep the changes to a minimum.

If it is to your liking you can accept the PR, which consists of:

• Copyright and Caption support: especially in asset recycling it is widely used.
• Italian translation: as per voice
• Show image ID: in our case it is used to interface the asset with an encoder of the asset
• Search within metadata: since we cannot change the filename we felt the best way is to search within the alt text (but when in doubt in any field)

Thanks for your attention and good work :)

Hi! Haven't you noticed that the encode function wreak the file path? It changes slashes to %2F in paths. Instead of return urlencode(urldecode($fileName)); I do return dirname($fileName)."/".urlencode(urldecode(basename($fileName)));

hi, I am using Inertia js, I need to customize the returned value instead of "image id" -> "https://mydomain.com/media"file system drive"/projects"collection name"/project.png"image name not ID"

Is it possible to achieve that?