I find the Bookmarks feature really useful since I find myself in many different locations and on different computers. So I collect a large number of bookmarks.

To help me organize my Bookmarks, I'd like to request a new "Folder" feature in Bookmarks so I can group related Bookmarks together. I'm attaching a picture to help explain this concept. This concept is very similar to how Firefox and Chrome organize bookmarks.

I should probably mention I'm using OwnCloud 5.0.5 on OpenSUSE 12.2 x64 LAMP setup, and am brand new to OwnCloud.

Thank you, Craig

• [x] adding bookmarks (fixes #257)
• [x] bookmark search (fixes #131, fixes #297)
• [x] bulk editing (fixes #157)
  • [x] bulk deletion
  • [x] bulk tagging (fixes #12; fixes #286)
• [x] Import & export
  • [x] Import: use fetch() API if available (fixes #423, fixes #80)
  • [x] Use new upload ui (fixes #255 )
• [x] Responsive design (fixes #430)
• [x] editing bookmarks (fixes #437)
• [x] editing tags
• [x] website images (fixes #292)
  • [x] grid view (fixes #55)
• [x] translatability
• [ ] accessibility
• [x] advanced tag filter (fixes #168)
  • [ ] 'Untagged' menu item (do we really need this when we have bulk editing and no more reloads?)
• [ ] ~~sharing (#5)~~

Installation:

git clone #-this-repo-#
git checkout feature/new-ui
composer install
npm install
npm run build

old pr: #402

Describe the bug @marcelklehr Looks like the bookmark API is broken for android app To Reproduce Steps to reproduce the behavior:

1. Install nextcloud on docker
2. Enable bookmark app
3. Try to access via Endpoint API.
4. Giving Errror

2020-05-03 22:08:31.558 27693-27693/org.bisw.nxbookmarks D/ViewRootImpl@223ec4e[LoginAcitivty]: ViewPostIme pointer 0 2020-05-03 22:08:31.672 27693-27693/org.bisw.nxbookmarks D/ViewRootImpl@223ec4e[LoginAcitivty]: ViewPostIme pointer 1 2020-05-03 22:08:31.681 27693-28005/org.bisw.nxbookmarks E/ocbookmarkstag: apiRootUrl value is https:https://127.0.0.1:8080/index.php/apps/bookmarks/public/rest/v2 2020-05-03 22:08:31.683 27693-28005/org.bisw.nxbookmarks I/System.out: (HTTPLog)-Static: isSBSettingEnabled false 2020-05-03 22:08:31.684 27693-28005/org.bisw.nxbookmarks I/System.out: (HTTPLog)-Static: isSBSettingEnabled false 2020-05-03 22:08:31.690 27693-28005/org.bisw.nxbookmarks W/System.err: org.schabi.ocbookmarks.REST.RequestException: java.net.ConnectException: Failed to connect to /127.0.0.1:8080 2020-05-03 22:08:31.690 27693-28005/org.bisw.nxbookmarks W/System.err: at org.schabi.ocbookmarks.REST.OCBookmarksRestConnector.send(OCBookmarksRestConnector.java:136) 2020-05-03 22:08:31.691 27693-28005/org.bisw.nxbookmarks W/System.err: at org.schabi.ocbookmarks.REST.OCBookmarksRestConnector.getRawBookmarks(OCBookmarksRestConnector.java:198) 2020-05-03 22:08:31.691 27693-28005/org.bisw.nxbookmarks W/System.err: at org.schabi.ocbookmarks.REST.OCBookmarksRestConnector.getBookmarks(OCBookmarksRestConnector.java:220) 2020-05-03 22:08:31.691 27693-28005/org.bisw.nxbookmarks W/System.err: at org.schabi.ocbookmarks.LoginAcitivty$TestLoginTask.doInBackground(LoginAcitivty.java:117) 2020-05-03 22:08:31.691 27693-28005/org.bisw.nxbookmarks W/System.err: at org.schabi.ocbookmarks.LoginAcitivty$TestLoginTask.doInBackground(LoginAcitivty.java:111) 2020-05-03 22:08:31.691 27693-28005/org.bisw.nxbookmarks W/System.err: at android.os.AsyncTask$3.call(AsyncTask.java:378) 2020-05-03 22:08:31.691 27693-28005/org.bisw.nxbookmarks W/System.err: at java.util.concurrent.FutureTask.run(FutureTask.java:266) 2020-05-03 22:08:31.691 27693-28005/org.bisw.nxbookmarks W/System.err: at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:289) 2020-05-03 22:08:31.691 27693-28005/org.bisw.nxbookmarks W/System.err: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) 2020-05-03 22:08:31.691 27693-28005/org.bisw.nxbookmarks W/System.err: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) 2020-05-03 22:08:31.691 27693-28005/org.bisw.nxbookmarks W/System.err: at java.lang.Thread.run(Thread.java:919) 2020-05-03 22:08:31.691 27693-28005/org.bisw.nxbookmarks W/System.err: Caused by: java.net.ConnectException: Failed to connect to /127.0.0.1:8080 2020-05-03 22:08:31.692 27693-28005/org.bisw.nxbookmarks W/System.err: at com.android.okhttp.internal.io.RealConnection.connectSocket(RealConnection.java:1409) 2020-05-03 22:08:31.692 27693-28005/org.bisw.nxbookmarks W/System.err: at com.android.okhttp.internal.io.RealConnection.connect(RealConnection.java:1359) 2020-05-03 22:08:31.692 27693-28005/org.bisw.nxbookmarks W/System.err: at com.android.okhttp.internal.http.StreamAllocation.findConnection(StreamAllocation.java:221) 2020-05-03 22:08:31.692 27693-28005/org.bisw.nxbookmarks W/System.err: at com.android.okhttp.internal.http.StreamAllocation.findHealthyConnection(StreamAllocation.java:144) 2020-05-03 22:08:31.692 27693-28005/org.bisw.nxbookmarks W/System.err: at com.android.okhttp.internal.http.StreamAllocation.newStream(StreamAllocation.java:106) 2020-05-03 22:08:31.692 27693-28005/org.bisw.nxbookmarks W/System.err: at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:400) 2020-05-03 22:08:31.692 27693-28005/org.bisw.nxbookmarks W/System.err: at com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:333) 2020-05-03 22:08:31.692 27693-28005/org.bisw.nxbookmarks W/System.err: at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:483) 2020-05-03 22:08:31.692 27693-28005/org.bisw.nxbookmarks W/System.err: at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:429) 2020-05-03 22:08:31.692 27693-28005/org.bisw.nxbookmarks W/System.err: at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:252) 2020-05-03 22:08:31.693 27693-28005/org.bisw.nxbookmarks W/System.err: at com.android.okhttp.internal.huc.DelegatingHttpsURLConnection.getInputStream(DelegatingHttpsURLConnection.java:211) 2020-05-03 22:08:31.693 27693-28005/org.bisw.nxbookmarks W/System.err: at com.android.okhttp.internal.huc.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:30) 2020-05-03 22:08:31.693 27693-28005/org.bisw.nxbookmarks W/System.err: at org.schabi.ocbookmarks.REST.OCBookmarksRestConnector.send(OCBookmarksRestConnector.java:126) 2020-05-03 22:08:31.693 27693-28005/org.bisw.nxbookmarks W/System.err: ... 10 more

Expected behavior Normally Android App open the bookmarks list from the andrid app.

Screenshots

Server (please complete the following information):

• OS: macos
• HTTP server: [e.g. nginx 1.1]
• Database [e.g. MySQL 5.3] Type: sqlite3 Version: 3.27.2
• PHP version: [e.g. v7.2] Version: 7.3.17
• Nextcloud version: [e.g. 15.0.1 (see Nextcloud admin page)] Nextcloud 18.0.4
• Bookmarks app version: [e.g. 1.1.0 (see Nextcloud apps page)] 3.0.7
• Activated Nextcloud Apps: [the output of running $ sudo -u www-data php occ app:list in your command line]
• Nextcloud configuration: [the output of running sudo -u www-data php occ config:list system]
• Nextcloud external user backend: [e.g. ldap, or none]

The Current version of bookmark does not allow to share bookmark using the sharing api.

Let the user share a tag with users and using a "private link".

Export a simple page with the bookmarks and an feed (atom, rss, ..) .

Hello there,

I'm happy to announce the first beta release of bookmarks v3.0.0, which most notably includes sharing among a few other goodies. (Update: You can only share folders: Click on folder 'details' and then go to the 'Sharing' tab)

I would be glad to hear your feedback after trying it out in this thread as well as possible bugs in new issues. Don't forget to backup your database before trying this out!

Requirements are:

• PHP v7.2+
• PHP extensions mbstring and intl
• Nextcloud v17+

Changes in this release are:

• dac2cc7c2db177199bd82ecdfaec027b47c72f2b UI: Selection: Implement "select all" and "cancel selection"
• cbdcbf1af0afea9f995eca8a43978c8898f899fb Better document how the screeenly api url looks like
• 84e889a5f9d52f94ffeb5b0658cf9b7eef1fd842 Move UI: Automatically open current folder
• 63ef98d745e9867f83e23905d46313f1a693f2c7 Implement bookmark counting endpoints and UI indicators
• 18df1c1cf4a56e5893059dde4f70bacaa31fc5d3 Fix bookmark creation: Assign folders correctly
• aa0963c3aef0bee254a7883ded7f91d8dc95ab86 Drop tables on uninstall
• 796d6c8a268fa86965f7d2f08925fc55691aa178 Fix import and export
• 93e2df6f923a62b778f2b0589cdd666b78e51c12 Allow editing URLs
• 1ad192cfd394acf547e8dccee947472cd95d86cf Implement a full children endpoint
• 79b2922d197d08463f239de77dd85a0cf2ee839d Breadcrumbs: -AddBookmark button +Add Folder/Bookmark dropdown
• b543fab1803bb6092ffe73ebdac0cf06baf3933a Don't enable scraping by default
• 6d656d3242ea8f34b9d8c3a193168c80214d1f94 Drop libgmp dependency
• 768f311da5620379ea39a5e93f7eb7fa7fb854ed Implement hash caching
• Implement sharing and public links
• Major backend refactoring

Update: Here's the link to beta 2: https://github.com/nextcloud/bookmarks/releases/tag/v3.0.0-beta.2

Cheers! :space_invader:

Describe the bug Today I updated bookmarks in my NC installation to 3.0.2 and now on all of my computers I get an sync error in floccus on firefox. Error Code: E018 Authentification failed. I deleted my floccus account set up a new one but same error. I had no issues until updating to bookmarks 3 so I don't think it's on my side.

By the way, thanks for the work on that great app!!

To Reproduce Steps to reproduce the behavior:

1. Update to Bookmarks 3.0.2
2. Sync with Floccus extension on Firefox

Expected behavior Sync should be ok.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: MacOS X Catalina
• Browser Firefox
• Version 75

Server (please complete the following information):

• OS: linux shared hosting
• HTTP server: nginx
• Database MySQL 5.3
• PHP version: 7.3.11
• Nextcloud version: 18.0.4
• Bookmarks app version: 3.0.2

Describe the bug Every 12 hours, when cron.php attempts to run CrawlJob, it gets stuck. Subsequent cron jobs will not run until it completes, so I get messages in Basic Settings -> Background jobs to the effect of "cron has not run in 10 hours, something looks wrong". Upon noticing that cron.php is stuck, I manually kill the php7 process, and cron.php runs normally at the next scheduled time and continues to do so for 12 more hours.

To Reproduce Steps to reproduce the behavior:

1. Set up cron to run cron.php every 5 minutes
2. Upgrade to Bookmarks 4.1.0 (Not really sure when the issue started, took me a while to figure out it was related to the Bookmarks App.)
3. Wait for cron.php to execute CrawlJob (I don't know why it does not run every 5 minutes, but in oc_jobs, last_checked == last_run == reserved_at == the last time cron.php ran and is now stuck.
4. See error

Expected behavior cron.php should run CrawlJob to completion, or report an error and quit so that cron.php may run again in the future.

Screenshots User http's crontab:

# crontab -l -u http
*/5  *  *  *  * /usr/bin/php7 -f /usr/share/webapps/nextcloud/cron.php &> /dev/null
7-57/15  *  *  *  * /usr/bin/php7 /usr/share/webapps/nextcloud/occ preview:pre-generate &> /dev/null

CrawlJob entry in oc_jobs:

$ mysql -uxxxxxxxx -pxxxxxxxx -D nextcloud -e 'select * from oc_jobs where reserved_at > 0;'
+-------+---------------------------------------+----------+------------+--------------+-------------+--------------------+
| id    | class                                 | argument | last_run   | last_checked | reserved_at | execution_duration |
+-------+---------------------------------------+----------+------------+--------------+-------------+--------------------+
| 13377 | OCA\Bookmarks\BackgroundJobs\CrawlJob | null     | 1618222913 |   1618222913 |  1618222913 |                  0 |
+-------+---------------------------------------+----------+------------+--------------+-------------+--------------------+

Desktop (please complete the following information):

• OS: Arch Linux
• Browser: Firefox
• Version: 87

Server (please complete the following information):

• OS: Arch Linux
• HTTP server: nginx-mainline 1.19.9-1
• Database: mariadb 10.5.9-1
• PHP version: php7 7.4.16-1
• Nextcloud version: 20.0.8
• Bookmarks app version: 4.1.0
• Activated Nextcloud Apps: [the output of running $ sudo -u www-data php occ app:list in your command line]

# runuser -u http -- php7 /usr/share/webapps/nextcloud/occ app:list
Enabled:
 - accessibility: 1.6.0
 - activity: 2.13.4
 - announcementcenter: 4.0.1
 - apporder: 0.12.0
 - bookmarks: 4.1.0
 - bruteforcesettings: 2.1.0
 - calendar: 2.2.0
 - carnet: 0.23.8
 - cloud_federation_api: 1.3.0
 - cms_pico: 1.0.15
 - comments: 1.10.0
 - contacts: 3.5.1
 - contactsinteraction: 1.1.0
 - cookbook: 0.8.4
 - dashboard: 7.0.0
 - dav: 1.16.2
 - federatedfilesharing: 1.10.2
 - federation: 1.10.1
 - files: 1.15.0
 - files_markdown: 2.3.3
 - files_pdfviewer: 2.0.1
 - files_rightclick: 0.17.0
 - files_sharing: 1.12.2
 - files_texteditor: 2.14.0
 - files_trashbin: 1.10.1
 - files_versions: 1.13.0
 - files_videoplayer: 1.9.0
 - firstrunwizard: 2.9.0
 - logreader: 2.5.0
 - lookup_server_connector: 1.8.0
 - nextcloud_announcements: 1.9.0
 - notes: 4.0.4
 - notifications: 2.8.0
 - oauth2: 1.8.0
 - password_policy: 1.10.1
 - passwords: 2021.4.0
 - phonetrack: 0.6.7
 - photos: 1.2.3
 - previewgenerator: 3.1.1
 - privacy: 1.4.0
 - provisioning_api: 1.10.0
 - recommendations: 0.8.0
 - serverinfo: 1.10.0
 - settings: 1.2.0
 - sharebymail: 1.10.0
 - spreed: 10.0.6
 - support: 1.3.0
 - survey_client: 1.8.0
 - systemtags: 1.10.0
 - tasks: 0.13.6
 - text: 3.1.0
 - theming: 1.11.0
 - twofactor_backupcodes: 1.9.0
 - unsplash: 1.2.2
 - updatenotification: 1.10.0
 - user_status: 1.0.1
 - viewer: 1.4.0
 - weather: 1.7.5
 - weather_status: 1.0.0
 - workflowengine: 2.2.0
Disabled:
 - admin_audit
 - dicomviewer
 - encryption
 - files_external
 - user_ldap

• Nextcloud configuration: [the output of running sudo -u www-data php occ config:list system]

# runuser -u http -- php7 /usr/share/webapps/nextcloud/occ config:list system
{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "monster.bostrom.org",
            "gremlin.homelinux.org"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "defaultapp": "apporder",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "20.0.8.1",
        "logtimezone": "UTC",
        "log_rotate_size": 16777216,
        "loglevel": 0,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "asset-pipeline.enabled": false,
        "session_lifetime": 21600,
        "session_keepalive": true,
        "installed": true,
        "theme": "",
        "maintenance": false,
        "htaccess.RewriteBase": "\/nextcloud",
        "mail_smtpmode": "smtp",
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpsecure": "ssl",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "465",
        "mail_smtpauth": 1,
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "enable_previews": true,
        "preview_max_x": 1024,
        "preview_max_y": 1024,
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "has_rebuilt_cache": true,
        "mysql.utf8mb4": true,
        "encryption.legacy_format_support": false,
        "encryption.key_storage_migrated": false,
        "trashbin_retention_obligation": "auto, 180"
    }
}

• Nextcloud external user backend: none

Additional context Add any other context about the problem here.

Web server error log

N/A

Nextcloud log (nextcloud/data/nextcloud.log)

I've not noticed any messages in nextcloud.log related to CrawlJob. It rolls over too fast due to all the OCP\SabrePluginEvent info messages generated.

Browser log

N/A

Describe the bug A clear and concise description of what the bug is.

To Reproduce

1. Deleted from 3.4.6 to 3.4.7 and now all bookmarks are gone.
2. Tested on laptop + desktop each with Brave / Firefox and same results.

Expected behavior I can see the bookmarks in Nextcloud "Recent" page, but all folders are gone

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information): OS Linux

Server (please complete the following information):

• OS: Debian 9
• HTTP server: Apache 2
• Database: MySQL 10.1
• PHP version: v7.2
• Nextcloud version: 19.0.4
• Bookmarks app version: 3.4.7
• Activated Nextcloud Apps: [the output of running $ sudo -u www-data php occ app:list in your command line]
• Nextcloud configuration: [the output of running sudo -u www-data php occ config:list system]
• Nextcloud external user backend: [e.g. ldap, or none]

Additional context Add any other context about the problem here.

OC 5 fails to import my bookmark html-file that I exported from firefox. Anyone else having problems?

When it happens, I only get

SQLSTATE[22001]: String data, right truncated: 7 ERROR:  value too long for type character varying(140) at [...]/lib/db.php#1031

in the log

From the bookmark app code I guess that's a problem with the bookmark title. Any particular reason the title does not have a maximum size of 4k, too?

Hello,

First, thanks for your recent work in the app. It is great to see that it is coming back to life.

Even though I really like the new tiled view, it would be great to keep the option of the classic list view (or some kind of list view). For some of us it is easier to read.

Thoughts?

Thanks again

Hello there,

the reason for this rewrite was the request of a friend who wanted to access his bookmarks remotely in json formatting to use them in his WordPress Plugin (https://github.com/mario-nolte/oc2wp-bookmarks).

While working on this i decided to refactor everything to make use of the app framework because of its routing features. The app now features a restful api but still includes some legacy routes, so that for example the android bookmark app still works.

Check out the full code: https://github.com/ganomi/bookmarks

Features: Dependency Injection for user and db is used througout the controllers The Routing features a consistent rest api The Routing provides some legacy routes, so that for exampe the Android Bookmarks App still works. There is a publicly available api that provides access to bookmarks per user. (This is usefull in connection with the WP Plugin https://github.com/mario-nolte/oc2wp-bookmarks)

This pull request now also features all the changes from Pull Request https://github.com/owncloud/bookmarks/pull/68 as well and all fixes to keep the original style and usability.

Bumps @nextcloud/eslint-config from 8.1.4 to 8.1.5.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.

Bumps @nextcloud/router from 2.0.0 to 2.0.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.

Bumps @nextcloud/vue from 7.2.0 to 7.3.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.

Bumps sanitize-html from 2.7.3 to 2.8.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.

Is your feature request related to a problem? Please describe. Bookmarks app does not download files larger than 90 KB. This is related to a bug in the CrawlService.php, where the comment says the maximum size is 90MiB but its only 90 KB. https://github.com/nextcloud/bookmarks/blob/cb6663202b7ca80f389711221362b1bab0fb8a59/lib/Service/CrawlService.php#L33

Describe the solution you'd like Allow users to specify the maximum size in the setting

Describe alternatives you've considered Fix the bug in the code.

Additional context Add any other context or screenshots about the feature request here.

Bumps cirrus-actions/rebase from 1.7 to 1.8.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.