This proposal does not change existing classes of the component, because I wanted an implementation for version 2 of zend-navigation.

Caution

This PR based on PHPUnit 5.7 || 6.0! See: #59

ping @weierophinney @RalfEggert @webimpress

Hello,

following a short discussion with @froschdesign I report an issue with the github markdown parser regarding pipe symbols.

The pipe sign | in markdown has a special meaning for tables and must therefore be commented out if used otherwise. As an example, have a look at the table in menu.md.

The final documentation doesn't show the error, but github and maybe other markdown parsers do.

Cheers, LT.

From Fedora CI https://apps.fedoraproject.org/koschei/package/php-zendframework-zend-navigation

After upgrade of zend-mvc to 2.7.3 and zend-view-2.6.4

PHPUnit 5.2.10 by Sebastian Bergmann and contributors.
...............................................................  63 / 179 ( 35%)
............................................................... 126 / 179 ( 70%)
.................................................PHP Fatal error:  Call to a member function attach() on boolean in /usr/share/php/Zend/View/Helper/Navigation/AbstractHelper.php on line 959

In travis build some component are 3.x (at least zend-stdlib)

The quick start guide is wrong. First (small) issue, it has a very obvious syntax error https://docs.zendframework.com/zend-navigation/quick-start/. Look at the array( part in the first code block.

The second issue is worse, and it is plain wrong and its one of the weirdest parts of the navigation module in my opinion. It says to use <?= $this->navigation('default')->menu() ?>, but you will get an error then. You have to use <?= $this->navigation('navigation')->menu() ?> instead.

It's originally I commented at https://github.com/zendframework/zend-view/issues/45. I use latest zf2 :

"zendframework/zendframework": "^2.5"

The stacktrace is:

Fatal error: 'continue' not in the 'loop' or 'switch' context in /Users/samsonasik/www/MyProject/vendor/zendframework/zend-view/src/Helper/Navigation/PluginManager.php on line 62
Call Stack
#   Time    Memory  Function    Location
1   0.0002  368728  {main}( )   .../index.php:0
2   0.0843  4939896 Zend\Mvc\Application->run( )    .../index.php:21
3   0.0945  5351360 Zend\Mvc\Application->completeRequest( )    .../Application.php:328
4   0.0945  5351360 Zend\EventManager\EventManager->trigger( )  .../Application.php:353
5   0.0945  5351416 Zend\EventManager\EventManager->triggerListeners( ) .../EventManager.php:214
6   0.0947  5353104 call_user_func:{/Users/samsonasik/www/MyProject/vendor/zendframework/zend-eventmanager/src/EventManager.php:490} ( )    .../EventManager.php:490
7   0.0947  5353104 Zend\Mvc\View\Http\DefaultRenderingStrategy->render( )  .../EventManager.php:490
8   0.0947  5353104 Zend\View\View->render( )   .../DefaultRenderingStrategy.php:103
9   0.1215  5373872 Zend\View\Renderer\PhpRenderer->render( )   .../View.php:207
10  0.1217  5411144 include( '/Users/samsonasik/www/MyProject/module/Application/view/layout/layout.phtml' )    .../PhpRenderer.php:502
11  0.1331  5936048 Zend\View\Helper\Navigation->menu( )    .../layout.phtml:55
12  0.1331  5936104 Zend\View\Helper\Navigation->__call( )  .../layout.phtml:55
13  0.1331  5936104 Zend\View\Helper\Navigation->findHelper( )  .../Navigation.php:112
14  0.1331  5936104 Zend\View\Helper\Navigation->getPluginManager( )    .../Navigation.php:151
15  0.1331  5936104 spl_autoload_call ( )   .../Navigation.php:325
16  0.1331  5936264 Composer\Autoload\ClassLoader->loadClass( ) .../Navigation.php:325
17  0.1331  5936424 Composer\Autoload\includeFile( )    .../ClassLoader.php:301

https://github.com/zendframework/zend-navigation/blob/master/src/Service/AbstractNavigationFactory.php#L56

Method createService has a wrong signature implementing Zend\ServiceManager\FactoryInterface. It should be createService(ServiceLocatorInterface $serviceLocator); with just one parameter!

As of PHP 7.2 you'll receive a Fatal Error.

Hello,

After trying for a few hours to make the zend navigation work, when upgrading from ZF2(2.4) to ZF3, i think i have found a problem with method: Zend\Navigation\AbstractContainer->hasChildren() In the past it used to work like this (in ZF 2.4):

• it would return true if page on which method was called had child pages; Now it does not work like this, but does the following:
• it returns true if first child of current page (on which method is called) has child pages
• this seems not ok to me, but i may be wrong;

Is this a problem or not ?

Thank you !

In the following example i create a navigation with two levels and then print the navigation labels with echo. As you can see i set an order for both first level pages and for two second level pages. If you look at my output you can see that only the first level pages are in right order. The second level pages arent in right order.

For every level you put in a navigation greater than level one, the order isnt changed.

Anybody of you have the same problem or can tell me what iam doing wrong? Or is this a not given functionality of this module?

Testscript

$container = new \Zend\Navigation\Navigation(
    array(
        array(
            'label' => 'ACL page 1 (guest)',
            'uri' => '#acl-guest',
            'resource' => 'nav-guest',
            'order' => 777,
            'pages' => array(
                 array(
                     'label' => 'ACL page 1.1 (foo)',
                      'uri' => '#acl-foo',
                      'resource' => 'nav-foo',
                      'order' => 666
                  ),
                  array(
                      'label' => 'ACL page 1.2 (bar)',
                       'uri' => '#acl-bar',
                       'resource' => 'nav-bar',
                  ),
                  array(
                      'label' => 'ACL page 1.3 (baz)',
                       'uri' => '#acl-baz',
                       'resource' => 'nav-baz',
                  ),
                  array(
                      'label' => 'ACL page 1.4 (bat)',
                      'uri' => '#acl-bat',
                      'resource' => 'nav-bat',
                      'order' => 111
                  ),
              ),
          ),
          array(
              'label' => 'ACL page 2 (member)',
              'uri' => '#acl-member',
              'resource' => 'nav-member',
              'order' => 555
          )
      )
  );

  foreach ($container as $page) {
      echo $page->label."<br>";
      if ($page->hasPages()) {
          foreach ($page->getPages() as $page2) {
              echo $page2->label."<br>";
          }
      }
  }
  die("ASD");

Output

ACL page 2 (member)
ACL page 1 (guest)
ACL page 1.1 (foo)
ACL page 1.2 (bar)
ACL page 1.3 (baz)
ACL page 1.4 (bat)
ASD

hi, i have a little question about Zend Navigataion. After following cookbook tutorial about setting locale without url param (https://docs.zendframework.com/zend-expressive/cookbook/setting-locale-without-routing-parameter/) i am a bit confused so maybe someone can help me here.

If i enter url like local.com/en/some-page my locale is set to english and all urls created with UrlHelper get '/en' part prepended but Zend Navigation is still rendering url without that '/en' part.

What should i do to make Zend Navigation prepend that '/en/' part to all created links just like UrlHelper? ps. i am using froschdesign/zend-navigation - feature/expressive-support branch

Fix #69. No need to dynamically request service name, when its known that Navigation::class is one ultimately being requested in __invoke

Test will not run against 7.2 because #59 is against dev, while that branch is probably tested against SM3 making this less relevant. Although, test for general creation ability can be ported to improve coverage.

I've created navigation in the configuration file, according to example in Quick Star documentation. It worked with single menu, but once I've tried multiple menu approach I receive the following error:

Fatal error: Uncaught Zend\ServiceManager\Exception\ServiceNotFoundException: Unable to resolve service "ZendNavigationDefault" to a factory; are you certain you provided it during configuration?

The way I call the methof {% for page in navigation('Zend\Navigation\Default').container %} <a href="{{ url(page.route) }}" class="navbar-item">{{ page.label }}</a> {% endfor %}

I want to use Zend\Navigation in a Zend\Expressive application. First of all, I installed it:

composer require zendframework/zend-navigation

Composer installed it and added the ConfigProvider to my /config/config.php file:

$configManager = new ConfigManager(
    [
        Zend\I18n\ConfigProvider::class,
        Zend\Form\ConfigProvider::class,
        Zend\InputFilter\ConfigProvider::class,
        Zend\Hydrator\ConfigProvider::class,
        Zend\Session\ConfigProvider::class,
        TravelloViewHelper\ConfigProvider::class,
        new PhpFileProvider($pattern),
    ],
    $cachedConfigFile
);

When I try to use the navigation view helper in a template, I get this error:

A plugin by the name "navigation" was not found in the plugin manager Zend\View\HelperPluginManager

So, I added the Zend\Navigation\View\ViewHelperManagerDelegatorFactory to my configuration:

return [
    'dependencies' => [
        'delegators' => [
            Zend\View\HelperPluginManager::class => [
                Zend\Navigation\View\ViewHelperManagerDelegatorFactory::class,
            ],
        ],
    ],
];

No I get this error:

Unable to resolve service "Application" to a factory; are you certain you provided it during configuration?

After some investigation the problem is located here:

https://github.com/zendframework/zend-navigation/blob/master/src/Service/AbstractNavigationFactory.php#L102

The AbstractNavigationFactory seems to have a hard dependency on the MVC application which makes it impossible to use Zend\Navigation with Zend\Expressive currently.

Are there any plans to solve this? What should be done to break up this hard dependency? I guess it would be quite complicated to run Zend\Navigation both with Zend\Mvc and Zend\Expressive, wouldn't it?

I found this code snippet in den documenation for the zend-navigation component (ZF3):

Docs » Reference » View Helpers » Intro

The Code snippet provided is not working for me:

<?php
// module/MyModule/Module.php

namespace MyModule;

use Zend\View\HelperPluginManager;
use Zend\Permissions\Acl\Acl;
use Zend\Permissions\Acl\Role\GenericRole;
use Zend\Permissions\Acl\Resource\GenericResource;

class Module
{
    /* ... */
    public function getViewHelperConfig()
    {
        return [
            'factories' => [
                // This will overwrite the native navigation helper
                'navigation' => function(HelperPluginManager $pm) {
                    // Setup ACL:
                    $acl = new Acl();
                    $acl->addRole(new GenericRole('member'));
                    $acl->addRole(new GenericRole('admin'));
                    $acl->addResource(new GenericResource('mvc:admin'));
                    $acl->addResource(new GenericResource('mvc:community.account'));
                    $acl->allow('member', 'mvc:community.account');
                    $acl->allow('admin', null);

                    // Get an instance of the proxy helper
                    $navigation = $pm->get('Zend\View\Helper\Navigation');

                    // Store ACL and role in the proxy helper:
                    $navigation->setAcl($acl);
                    $navigation->setRole('member');

                    // Return the new navigation helper instance
                    return $navigation;
                }
            ]
        ];
    }
    /* ... */
}

First it seems that in ZF3 the HelperPluginManager is not passed to the closure. Instead, I found out that the parent ServiceManager is passed.

If I change it to the code below, then the example is working for me:

class Module
{
    /* ... */
    public function getViewHelperConfig()
    {
        return [
            'factories' => [
                // This will overwrite the native navigation helper
                Helper\Navigation::class => function(\Zend\ServiceManager\ServiceLocatorInterface $serviceManager)
                {
                    $navigationViewHelper = new \Zend\View\Helper\Navigation();
                    $navigationViewHelper->setServiceLocator($serviceManager);

                    // Store ACL and role in the proxy helper:
                    $navigationViewHelper->setAcl($this->acl);
                    $navigationViewHelper->setRole($this->role);

                    // Return the new navigation helper instance
                    return $navigationViewHelper;
                }
            ]
        ];
    }
    /* ... */
}

Am I right? Is the documentation for ZF3 not correct?

The HelperConfigTest test case is marked incomplete currently due to the fact that Zend\View\Navigation\PluginManager is not updated to the latest zend-servicemanager changes. Once it has been, we can address this test case.