I cloned the database one week ago and the latest version of iodiorm would only return the last record in a set.

The example I used to prove it out was to create table called users and insert 16 users. Using the follow code I could only ever return the last record. A friend of mine working in the same code base confirmed the issue. I am on Linux and he is on OSX.

\ORM::configure('mysql:host=localhost;dbname=------');
\ORM::configure('username', '----');
\ORM::configure('password', '----');
\ORM::configure('logging', true);

$people = \ORM::forTable('users')->findMany();

I have a little more info on Stackoverflow and this was all done using the latest code from Git.

Pull based on https://github.com/j4mie/idiorm/issues/132

Added find_many return associative keys. Micro optimizations for Idiorm and Paris. set and set_expr returns the instance, to admit a fluent query

Hi,

I added a function.

ORM::for_table('people')->none()->find_many();

That is guaranteed to return an empty set. This code devolves down to the following query:

SELECT * FROM `person` WHERE 0;

The reasons for having a dedicated function are:

• Syntatic sugar: none or a similarly named function makes more sense than where_raw(0)
• Possibility to optimise (by not actually executing the query)

An example use of this code in Paris would be:

class User extends Model {

    public static function has_cookie($orm, $cookie_name) {
        if (isset($_COOKIE[$cookie_name]))  {
            $cookie = $_COOKIE[$cookie_name];
            return $orm->where('cookie', $cookie);
        }
        // Return empty set
        //return $orm->where_raw(0);
        return $orm->none();
    }

}

$users = Model::Factory('user')->filter('has_cookie', 'user')->find_many();

As requested, this is a manual merge of the code that was in pull request #37 with support of multiple connections and forcing the use of the TOP style limit for the dblib driver.

It is currently in use in it's current form in one my projects so I can attest that it's working.

HI,

Why not use PDOStatement :: rowCount to get the number of rows affected by the last statement.

This property could be populated in the _run function after the statement execution like this: $this->_rowCount = $statement->rowCount();

Regards,

Hi, I've added the raw_join function to the idiorm class. I find it very useful on optimizing the query and selecting the extra data from composite tables. Let me know if you find it appropriate, it actually copy/pasted version of the function _add_join_source without distinction between $join_operator and $table and skiping the _quote_identifier.

I'm using Paris and idiorm for one of my sites and I've got lots of foreign key relationships expressed like this:

public function children() {
  return $this->has_many('Child')->find_many();
}

The problem is that each time I execute the children() function on the same object, idiorm executes the following SQL (for example):

SELECT * FROM child WHERE parent_id = 1

If I'm using information about the children several times on the same page - e.g. checking whether there are any children using count(), then iterating over them - there are lots of unnecessary queries made. I'm never going to change the data once I've entered a view, so if idiorm was able to cache these queries that would be really helpful for my application.

Hello,

I'm using Idiorm 1.3.0 with MySQL 5.5.9 / PHP 5.3.5, and I'm getting troubles when using both ORM::get_db()->exec() and ORM::raw_execute().

I'm trying to use this as a raw query : TRUNCATE table_name. But, when using these two methods :

ORM::get_db()->exec('TRUNCATE table_name');
ORM::raw_execute('TRUNCATE table_name');

I get the same error :

Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[HY000]: General error: 1 near "TRUNCATE": syntax error'

But I don't have any ideas from where this comes from :/

Refactor join() to implode() as of deprecated warning in PHP 7.4... therefore some strict unit testing suites (like mine) that turn warnings into errors are going to fail.

While fixing PHPUnit to support 5.x up to 7.4 it turns out that we cannot support both. PHP 7.4 needs PHPUnit 8 at least - that release enforces return types for setUp and tearDown that will cause syntax error in 5.x...

So now this is an dead end accept we create a testing suite for 5.x and 7.4+

• I had to put lot of work into fixing Travis CI - PHP 7.4 is not passing at the moment!
• HHVM has been removed because composer no longer supports it: https://github.com/composer/composer/issues/8127
• Added hack to bootstrap to support old and new PHPUnit namespace

if (class_exists('\PHPUnit\Framework\TestCase')) {
	class PHPUnit_Framework_TestCase extends \PHPUnit\Framework\TestCase
	{
	}
}

Supported PHPUnit versions: https://phpunit.de/supported-versions.html

How do you feel about having the methods converted to camel case so it is compliant with the PSR-1 spec? (https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md)

If you are open to it I can definitely help with the changes!

Hi!

I was quite impressed by compact and clean code of idiorm - so, I'm giving it a try in project where Postgresql database is be used. Problem I had was with ORM::_quote_identifier_part() - which quotes table/column names with "`", but a SQL statement in postgres commits seppuku when treated that way :) Could quoting character be made as a configuration option?

.. code-block:: php

protected function _quote_identifier_part($part) {
   $quote = self::$_config['identifier_quote_ch'];
   return $quote . $part . $quote;
}

Or - probably, identifier quoting could be called as a callback, leaving ORM::_quote_identifier_part just as a default method for that and be overridable in configuration?

How do You feel about such changes? What the correct approach would be?

Version: v1.5.8

Output Deprecated: PDO::quote(): Passing null to parameter #1 ($string) of type string is deprecated in C:\VHOST\VHOST8\idiorm\vendor\j4mie\idiorm\idiorm.php on line 539

Testing Code

<?php
declare(strict_types=1);
require_once "vendor/autoload.php";
date_default_timezone_set('Asia/Hong_Kong');
ini_set("assert.exception", "1");
//error_reporting(E_ALL & ~E_DEPRECATED);

/*
CREATE TABLE `testing` (
	`id` INT(11) NOT NULL AUTO_INCREMENT,
	`timestamp` DATETIME NULL DEFAULT current_timestamp() ON UPDATE current_timestamp(),
	PRIMARY KEY (`id`) USING BTREE
) COLLATE='utf8_general_ci' ENGINE=InnoDB;
*/
try{
    $hFile = fopen(__DIR__.DIRECTORY_SEPARATOR."run.log", 'w');
    $writeLine = function(string $message) use ($hFile):void{
        fwrite($hFile, $message.PHP_EOL);
    };
    $arrConfig = [
        'connection_string'=>'mysql:host=localhost;dbname=temp',
        'username'=>'root',
        'password'=>'P@ssw0rd',
        'return_result_sets'=>TRUE,
        'driver_options'=>[PDO::MYSQL_ATTR_INIT_COMMAND => 'SET NAMES utf8'],
        'error_mode'=>PDO::ERRMODE_EXCEPTION,
        'logging' => TRUE,
        'logger' => function($query, $time) use ($writeLine):void{
            $log = sprintf("[SQL %07.3f] %s", $time, $query);
            $writeLine($log);
        },
    ];
    ORM::configure($arrConfig);
    $orm = ORM::forTable("testing")->create();
    if(!$orm->save()) $writeLine("Create Fails");
    $id = intval($orm->id);
    $orm = ORM::forTable("testing")->findOne($id);
    $writeLine("Id# {$id} and get ".($orm->timestamp??"<NULL>"));
    $orm->timestamp = '2022-12-12 12:12:12';
    $orm->save();
    $writeLine("Id# {$id} and get ".($orm->timestamp??"<NULL>"));
    $orm->timestamp = NULL;
    $orm->save();
    $writeLine("Id# {$id} and get ".($orm->timestamp??"<NULL>"));
    if($hFile) fclose($hFile);
} catch (Throwable $ex){
    $writeLine("[Throwable] ".$ex->getMessage());
    if($hFile) fclose($hFile);
}

Beside the notice, the logged SQL is not correct. [SQL 000.007] UPDATEtestingSETtimestamp= '' WHEREid= '8'

MSSQL fails with an SQLSTATE[42000]: [Microsoft][ODBC Driver 17 for SQL Server][SQL Server] syntax error when using offset()...

1. TOP and OFFSET are not allowed to be used in one SELECT
2. OFFSET 10 ROWS with FETCH NEXT 10 ROWS ONLY should be used
3. Therefore _build_limit() and _build_offset() need some rework

This are my approaches but I think something is missing to work properly:

protected static function _detect_limit_clause_style($connection_name) {
    switch(self::get_db($connection_name)->getAttribute(PDO::ATTR_DRIVER_NAME)) {
        case 'dblib':
            return ORM::LIMIT_STYLE_TOP_N;
        case 'sqlsrv':
        case 'mssql':
            return ORM::LIMIT_STYLE_FETCH;
        default:
            return ORM::LIMIT_STYLE_LIMIT;
    }
}

protected function _build_limit() {
    $fragment = '';
    if (!is_null($this->_limit)) {
        if (self::$_config[$this->_connection_name]['limit_clause_style'] == ORM::LIMIT_STYLE_LIMIT) {
            if (self::get_db($this->_connection_name)->getAttribute(PDO::ATTR_DRIVER_NAME) == 'firebird') {
                $fragment = 'ROWS';
            } else {
                $fragment = 'LIMIT';
            }
            $fragment .= " {$this->_limit}";
        } else if (self::$_config[$this->_connection_name]['limit_clause_style'] == ORM::LIMIT_STYLE_FETCH) {
            $fragment = 'FETCH NEXT ' . $this->_limit . ' ROWS ONLY';
        }
    }
    return $fragment;
}

protected function _build_offset() {
    if (!is_null($this->_offset)) {
        $clause = 'OFFSET';
        if (self::get_db($this->_connection_name)->getAttribute(PDO::ATTR_DRIVER_NAME) == 'firebird') {
            $clause = 'TO';
        }
        if (self::$_config[$this->_connection_name]['limit_clause_style'] == ORM::LIMIT_STYLE_FETCH) {
            return $clause . ' ' . $this->_offset . '  ROWS';
        }
        return $clause . ' ' . $this->_offset;
    }
    return '';
}

Reference: http://www.sqlservertutorial.net/sql-server-basics/sql-server-offset-fetch/ https://stackoverflow.com/questions/2135418/equivalent-of-limit-and-offset-for-sql-server