Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php7 Compatibility problem #106

Open
oasfuyou opened this issue Aug 24, 2018 · 5 comments
Open

php7 Compatibility problem #106

oasfuyou opened this issue Aug 24, 2018 · 5 comments

Comments

@oasfuyou
Copy link

105 | ERROR | Function mcrypt_create_iv() is deprecated since PHP 7.1 and removed since PHP 7.2; Use random_bytes() or OpenSSL instead
105 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
105 | ERROR | The constant "MCRYPT_DEV_URANDOM" is deprecated since PHP 7.1 and removed since PHP 7.2

@bpearson
Copy link

bpearson commented Aug 24, 2018

This library shouldn't be used on any PHP version equal to 5.5 or higher. You should be able to use the native password_* functions.

@oasfuyou
Copy link
Author

oasfuyou commented Aug 24, 2018 via email

@xabbuh
Copy link

xabbuh commented Aug 24, 2018

That part of the code will never be executed on PHP 7 as the password_hash() function does exist there: https://github.com/ircmaxell/password_compat/blob/master/lib/password.php#L24

@Synchro
Copy link

Synchro commented Aug 24, 2018

...and if your code analyser is still complaining, it's a bug in your code analyser, not this lib.

@jrfnl
Copy link

jrfnl commented Oct 7, 2018

@oasfuyou These errors can be safely ignored (as long as they come from this package).

All the same, this is something which we could sort out in the new PHPCompatibilityPasswordCompat repo.
Would you mind opening an issue about it in that repo ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants