Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHVM (HipHop VM) current limits output to the first 255 bytes of output.... #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

navecommunications
Copy link

... If the prefix exceeds this, the returned string never contains

any added entropy, nor can it ever grow passed 255 bytes trapping us in an infinite loop if we request a larger string. Concatenating
the prefix and the generated should theoretically be faster through the uniqid function, so we'll only concatenate our own if we're
running HHVM, as well as have two seperate loops available so we only have to evalute if we're running HHVM once vs every iteration
of a singular loop.

…ut. If the prefix exceeds this, the returned string never contains

any added entropy, nor can it ever grow passed 255 bytes trapping us in an infinite loop if we request a larger string. Concatenating
the prefix and the generated should theoretically be faster through the uniqid function, so we'll only concatenate our own if we're
running HHVM, as well as have two seperate loops available so we only have to evalute if we're running HHVM once vs every iteration
of a singular loop.
@ircmaxell
Copy link
Owner

Why not open this as a bug against HHVM, as it's clearly working fine in core?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants