Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 more tests, 1 failing #10

Closed
wants to merge 2 commits into from
Closed

Added 2 more tests, 1 failing #10

wants to merge 2 commits into from

Conversation

SteveEdson
Copy link

The final test is currently failing however. See issue #9

The final test is currently failing however.
@SteveEdson
Copy link
Author

Any idea why this would be failing on my machine?

@bjeavons
Copy link
Owner

What version of PHP are you using?

@SteveEdson
Copy link
Author

Ahhhh I've figured it out. Packagist is recommending version 0.1.3, which is what I was using. This is failing for my tests.

The latest dev-master seems to be working correctly. Would it be possible to release a new version, so that I can use the fixes without being on the dev releases please?

Thanks.

@bjeavons
Copy link
Owner

Yes, you're running into what dc8aa91 fixes

https://github.com/bjeavons/zxcvbn-php/releases/tag/0.1.4

@bjeavons bjeavons closed this Jul 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants