Forgive me if I'm wrong, but should the regex pattern for GB VAT ids be wrapped in parens?

'GB' => '(\d{9}|\d{12}|(GD|HA)\d{3})'

Currently if you supply a valid VAT number with any random string after it, it still passes validation. Wrapping the pattern in parentheses fixes the issue, but wanted to raise this here first in case I was missing something obvious.

Because of BREXIT, the EU API (VIES) does not validate GB VATINs anymore. There is an API provided by the HMRC https://developer.service.hmrc.gov.uk/api-documentation/docs/api/service/vat-registered-companies-api/1.0#_get-a-vat-registration_get_accordion

Not sure if this is beyond the scope of this package.

This fixes #9 and #10 if a third parameter is passed to Validator::isValid.

When there is an error with the service, the third parameter becomes the return value, so set it to true to assume a valid number or false to assume an invalid number.

I'm not too sure whether it makes sense to have the default/null handled as it is currently, but I wanted to make sure that testWrongConnectionThrowsException passed. Any thoughts?

Changed log

• Use expectedException annotation to be compatible with the different PHPUnit version.
• Use the ::class approach directly in assertInstanceOf expected object.

The web service is not responding for me. I don't get results within 30 seconds. Is this simply a problem with VIES at the moment? Or is this service no longer available?

As reported by @PaddyLock at https://github.com/ddeboer/vatin-bundle/issues/4:

When checking the vat number existence against the VAT information exchange system service, the bundle does not catch an exception if the server is busy.

request.CRITICAL: Uncaught PHP Exception SoapFault: "SERVER_BUSY" at /var/www/releases/20141211152308/vendor/ddeboer/vatin/src/Ddeboer/Vatin/Vies/Client.php line 60 {"exception":"[object] (SoapFault: SERVER_BUSY at /var/www/releases/20141211152308/vendor/ddeboer/vatin/src/Ddeboer/Vatin/Vies/Client.php:60)"} []

Added CH validation rule and tests.

Furthermore, I had to increase the whitespaces because the CH check would have ruined the alignment of the comments.

Hi, I have recently had another uncaught Exception which occured several times in succession.

[2015-01-19 16:46:12] request.CRITICAL: Uncaught PHP Exception SoapFault: "MS_UNAVAILABLE" at /var/www/releases/20150107155314/vendor/ddeboer/vatin/src/Ddeboer/Vatin/Vies/Client.php line 60 {"exception":"[object](SoapFault: MS_UNAVAILABLE at /var/www/releases/20150107155314/vendor/ddeboer/vatin/src/Ddeboer/Vatin/Vies/Client.php:60)"} []

Is this related to #9 ?

Use CH country code here https://github.com/ddeboer/vatin/blob/master/src/Validator.php#L27 when VIES doesn't work with it. https://ec.europa.eu/taxation_customs/vies/faq.html?locale=lt#item_11

Hi, I am using the VATIN directly (no bundle) to validate with in a custom validator

if ($vatNumber != '') {
        $validator = new \Ddeboer\Vatin\Validator();

        try {
            $valid = $validator->isValid($vatNumber, true);
            if (!$valid) {
                $this->context->addViolation($constraint->message, array('%vatNumber%' => $vatNumber));
            }
        } catch (Exception $e) {

        }
    }

However, I still get an uncaught exception when there is a problem with the VIES service

[2015-06-03 09:14:14] request.CRITICAL: Uncaught PHP Exception Ddeboer\Vatin\Exception\ViesException: "Error communicating with VIES service" at /var/www/releases/20150603055730/vendor/ddeboer/vatin/src/Ddeboer/Vatin/Vies/Client.php line 67 {"exception":"[object] (Ddeboer\\Vatin\\Exception\\ViesException(code: 0): Error communicating with VIES service at /var/www/releases/20150603055730/vendor/ddeboer/vatin/src/Ddeboer/Vatin/Vies/Client.php:67, SoapFault(code: 0): SERVER_BUSY at /var/www/releases/20150603055730/vendor/ddeboer/vatin/src/Ddeboer/Vatin/Vies/Client.php:65)"}

If I use the validation with checkExistence=true

@Vatin(checkExistence=true)

I am getting the following error:

Error communicating with VIES service 500 Internal Server Error - ViesException 1 linked Exception: SoapFault »

ViesException: Error communicating with VIES service SoapFault: SERVER_BUSY

Can this Exception be caught?

Thanks

hi. i bumped php to 7.2. i suggest to bump further to php 7.4 as latest supported version (for this and your symfony-bundle). What is you opionen about that? https://php.watch/versions

github actions are added

Currently the method checkVat() just throws a ViesException with the message: 'Error communicating with VIES service'. Bit it is possible to give a more accurate message back. This is from the documentation of the https://ec.europa.eu/taxation_customs/vies/checkVatService.wsdl :

In case of problems, the returned FaultString can take the following specific values:

• INVALID_INPUT: The provided CountryCode is invalid or the VAT number is empty;

• GLOBAL_MAX_CONCURRENT_REQ: Your Request for VAT validation has not been processed; the maximum number of concurrent requests has been reached. Please re-submit your request later or contact [email protected] for further information": Your request cannot be processed due to high traffic on the web application. Please try again later;

• MS_MAX_CONCURRENT_REQ: Your Request for VAT validation has not been processed; the maximum number of concurrent requests for this Member State has been reached. Please re-submit your request later or contact [email protected] for further information": Your request cannot be processed due to high traffic towards the Member State you are trying to reach. Please try again later.

• SERVICE_UNAVAILABLE: an error was encountered either at the network level or the Web application level, try again later;

• MS_UNAVAILABLE: The application at the Member State is not replying or not available. Please refer to the Technical Information page to check the status of the requested Member State, try again later;

• TIMEOUT: The application did not receive a reply within the allocated time period, try again later.

It would be helpful to know why the check failed. Was it because of a wrong VAT number or a failed request? What do you think about throwing different exceptions or the ViesException with different messages? We could group it like

• INVALID_INPUT: "The provided CountryCode is invalid or the VAT number is empty"
• GLOBAL_MAX_CONCURRENT_REQ, MS_MAX_CONCURRENT_REQ, SERVICE_UNAVAILABLE, SERVICE_UNAVAILABLE, MS_UNAVAILABLE: "an error was encountered either at the network level or the Web application level, try again later"
• TIMEOUT: when there is a timeout the vatin check could try the validation for a second time. If it fails again the app would return the upper message/error.

We want to change the URL address and add a SOAP client timeout.

It would be helpful if the $wsdl property would be changed to protected (in order to extend the class and change the property) and if the options passed into the \SoapClient (second parameter) would be configurable using a protected property.

Related file is ddeboer/vatin/src/Vies/Client.php