Argument 1 passed to Coderello\SharedData\SharedData::__construct() must be of the type array, null given, called in D:\Work\Server\domains\luxwash\vendor\coderello\laravel-shared-data\src\Providers\SharedDataServiceProvider.php on line 41

Blade directive setup has been refactored:

• use Container::extend(), allowing lazy-load Blade compiler instantiation as well as correct functioning, when Blade package is not installed.

• Add 'blade.compiler' to SharedDataServiceProvider::provides(), ensuring SharedData as well as its Blade directive will be registered correctly once Blade is requested from Container

• Add the configuration for the Blade directive name, as 'shared' is too common and may conflict with other libraries.

Hi

As first thing I want congrat you for this package, this is very useful.

Deeping more, the window variable should not allow to change in client side (unless necessary). With this current render the windows var can set to new value window.sharedData.username = 'new user'.

My recommendation is to change the render function or maybe add new function as renderInmmutable() as like:

public function renderInmmutable(): string
    {
      
        return '<script>window[\''.$this->getJsNamespace().'\'] =  (() => {
                            
            let output = '.$this->toJson().';
                                    
            return { 
                data () {
                return output;
              }
            }
          })();</script>';
    }

Then youcan call it as: window.sharedData.data()

I appreciate your attention and feedback

Install error. issue with blade directive.

InvalidArgumentException

  The directive name [] is not valid. Directive names must only contain alphanumeric characters and underscores.

  at vendor/laravel/framework/src/Illuminate/View/Compilers/BladeCompiler.php:684
    680▕      */
    681▕     public function directive($name, callable $handler)
    682▕     {
    683▕         if (! preg_match('/^\w+(?:::\w+)?$/x', $name)) {
  ➜ 684▕             throw new InvalidArgumentException("The directive name [{$name}] is not valid. Directive names must only contain alphanumeric characters and underscores.");
    685▕         }
    686▕
    687▕         $this->customDirectives[$name] = $handler;
    688▕     }

      +19 vendor frames
  20  [internal]:0
      Illuminate\Foundation\Application::Illuminate\Foundation\{closure}()

      +5 vendor frames
  26  artisan:37
      Illuminate\Foundation\Console\Kernel::handle()

I found that your package make webpages not working on IE 11.

And I found why, it's because in the function getJsHelper of the file src/SharedData.php, the JS code generated use a default parameter (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters) in a function that is not compatible with IE.

Here is a correction that I tried and works well on IE.

window["'.$this->getJsHelperName().'"] = function(e) {
    var n = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : null;
    return [window.sharedDataNamespace].concat("string" == typeof e ? e.split(".") : []).reduce(function(e, t) {
        return e === n || "object" != typeof e || void 0 === e[t] ? n : e[t]
    }, window)
}

Can I send you a pull request to make your package compatible with IE, or you want to do it yourself ?

It would be handy to have an ability to specify the key transformer:

SharedData::keyTransformer(function ($key) {
    return Str::camel($key);
});

So that:

share(['auth_user' => auth()->user()]);

Will be transformed into:

{
    "authUser": {
        "id": 1,
        "firstName": "Ilya",
        "lastName": "Sakovich"
    }
}

Instead of storing entire $config array as internal property, configuration parameters are better to be split via particular fields. Especially, while there is only one configuration parameter - 'js_namespace'.

This refactoring creates more clean code and allows easy creation of standalone SharedData instance if necessary.

Attention: this is BC break change!

There is no way to use nonce content security policy, since Coderello\SharedData\SharedData::render() method returns <script> with no way to inject additional data.

public function render(): string
    {
        return '<script>'
            .'window["'.$this->getJsNamespace().'"]='.$this->toJson().';'
            .'window["sharedDataNamespace"]="'.$this->getJsNamespace().'";'
            .($this->getJsHelperEnabled() ? $this->getJsHelper().';' : '')
            .'</script>';
    }

I think either class constructor or render method could accept nonce value.

After installing spatie/laravel-ray, the @shared directive is not replaced anymore. Don't know if this is a bug in the spatie package or your package.

The html source only show @shared instead of the ja script...

After install on Laravel 8.0 + PHP 7.4:

`InvalidArgumentException

The directive name [] is not valid. Directive names must only contain alphanumeric characters and underscores.

at vendor/laravel/framework/src/Illuminate/View/Compilers/BladeCompiler.php:681 `

Any idea?

• Delayed closures (resolves #9)

share(function() {
    return ['user' => auth()->user()];
});

// or

share('user', function() {
    return auth()->user();
});

• Interfaces implementation (Arrayable, JsonSerializable, ArrayAccess)

• Tests refactoring

laravel.WARNING: Return type of Coderello\SharedData\SharedData::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/vagrant/code/liapp/vendor/coderello/laravel-shared-data/src/SharedData.php on line 203