Hi I need to use XBT currency, but when I set in config currency to XBT I get error that xbt is not supported by current repository. Do I need to change something to use xbt?

I was under the impression that money values should be stored in the database as VARCHAR to help with float rounding issues.

With that, the MoneyCast class seems use the DecimalFormatter to cast values to Money objects https://github.com/cknow/laravel-money/blob/master/src/MoneyCast.php#L44.

Shouldn't this use the normal formatter? Perhaps we could get the value, and if it doesn't contain a ".", use the normal formatter? So values like 1000 become $10.00.

Updating to the last version (coming from 3.8) I noticed all the amounts in my application multiplied by 100. It seems like the format() function does not divide by 100 anymore, so if I pass a value of 100 it will print 100 € (or whatever currency I set).

Rolling back to version 6.4.0 the problem disappears

Following up @atymic's issue https://github.com/cknow/laravel-money/issues/48, this draft contains a possible candidate to cast values into Money by leveraging the new Laravel 7 feature.

At this stage the cast can be defined in the following ways:

protected $casts = [
    // cast money using the currency defined in the package config
    'money' => MoneyCast::class,
    // cast money using the defined currency
    'money' => MoneyCast::class . ':AUD',
    // cast money using the currency defined in the model attribute 'currency'
    'money' => MoneyCast::class . ':currency',
];

In the example above, if the model attribute currency is null, the currency defined in the package configuration is used instead.

Setting money can be done in several ways:

$model->money = 10; // 10.00 USD or any other currency defined
$model->money = 10.23; // 10.23 USD or any other currency defined
$model->money = 'A$10'; // 10.00 AUD
$model->money = '1,000.23'; // 1000.23 USD or any other currency defined
$model->money = '10'; // 0.10 USD or any other currency defined
$model->money = new Cknow\Money\Money('10', new Money\Currency('EUR')); // 10 EUR

When we pass the model attribute holding the currency, such attribute is updated as well when setting money:

$model->currency; // null
$model->money = '€13';
$model->currency; // 'EUR'
$model->money->getAmount(); // '1300'

Given that only the class introduced in this PR implements the new interface CastsAttributes, we may not need a major version bump as long as the new tests (to be added once we agree on the implementation) are excluded from builds that use versions of Illuminate packages prior to 7.

Please let me know if you have any feedback or thoughts about the version bumping.

Hi,
I correctly installed the package, but I have these errors: This is my config/money.php:

'locale' => 'it_IT',
'currency' => 'EUR',

but I always get the dollar symbol if I use money(value) in blade file.

Other than that, in blade file @money(value) does not work.

Greetings!

First, thanks for putting this together. It really cleans up MoneyPHP and makes a nice, uniform way of working with it in Laravel.

After much debugging, I've narrowed down a deployment failure to App Engine as a failure of php artisan package:discover --ansi during the build process. If I remove this package, then the deployment works just fine.

The best I can tell from the build failure output is this hunk:

Step #1 - "builder": In Compiler.php line 36:
Step #1 - "builder":                                       
Step #1 - "builder":   Please provide a valid cache path.  

Please keep in mind that this only occurs if this package is installed. If I remove the package, then this error does not occur. This makes me think that this package is attempting to access something from the cache before things are ready.

This may have something to do with how App Engine introduces environment variables. In a normal Laravel setup the .env file provides the environment data and is loaded in, then accessible via the env. App Engine, conversely, has an app.yaml file that loads data as environment variables — rather than being loaded upfront. This still works, however, as the env function checks for environment variables as well.

If I find anything further I'll be sure to add a comment.

Bumps the dependencies to include Laravel ^7.0 variants.

I've forked and been running this locally, and it appears there's no breaking changes affecting the package in Laravel 7.

This fixes issue #107

The root cause for the worries was that the handling of integers and integerish values messes with the decimal casting. I fixed the parsing tests by forcing values directly into the database for the test and then retrieving (and casting) from there and forced handling of integers and integerish floats differently when casting into the database.

Seems there's an issue when trying to use the package on Laravel 9

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires cknow/laravel-money ^1.0 -> satisfiable by cknow/laravel-money[v1.0.0, v1.0.1, v1.0.2, v1.0.3].
    - cknow/laravel-money[v1.0.0, ..., v1.0.3] require illuminate/support ~5.1 -> found illuminate/support[v5.1.1, ..., 5.8.x-dev] but these were not loaded, likely because it conflicts with another require.

You can also try re-running composer require with an explicit version constraint, e.g. "composer require cknow/laravel-money:*" to figure out if any version is installable, or "composer require cknow/laravel-money:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.
ERROR: 2

The format() function doesn't get the actual precision parameter from the config file, here:

$value = number_format($amount, 2, $decimals, $thousands);

Changing the above line to:

$value = number_format($amount, $this->currency->getPrecision(), $decimals, $thousands);

That correctly reads the precision parameter, which is necessary for cents fraction and different subunit values.

A nice addition would be to remove leading zeros when using precision bigger than 2, for instance, if precision is 4, showing 0,5555 is ok, but 0,5500 should still be trimmed to 0,55.

Dears,

During my development i found that the currency fields doesn't get filled with new instances and i have to fill the currency manually

i checked the code and it seems that it checks if the field exists in the attribute before filling which for new instances wouldn't be correct.

so i don't think we need to do the check as it's already passed as a parameter.

For anyone facing the same issue you can just initialize the currency field using attributes inside the model

class Request extends Model
{
    protected $attributes = [
        'currency' => '',
    ];
}

Hi. After upgrading from v6 to v7 I got the following error:

    "class": "Money\\Exception\\UnknownCurrencyException",
    "message": "Cannot find currency 淠᎓翼",
    "code": 0,
    "file": "/var/app/test/vendor/moneyphp/money/src/Currencies/AggregateCurrencies.php:48",
    "trace": [
        "/var/app/test/vendor/moneyphp/money/src/Parser/IntlMoneyParser.php:56",
        "/var/app/test/vendor/moneyphp/money/src/Parser/AggregateMoneyParser.php:38",
        "/var/app/test/vendor/cknow/laravel-money/src/MoneyParserTrait.php:227",
        "/var/app/test/vendor/cknow/laravel-money/src/MoneyParserTrait.php:110",
        "/var/app/test/vendor/cknow/laravel-money/src/MoneyParserTrait.php:87",
        "/var/app/test/vendor/cknow/laravel-money/src/Casts/MoneyCast.php:62",
    ...

This problem was caused by this change and reproduced if intl extension was built with old ICU (in my case it is 50.2). It is default version with PHP 8.1 on fresh AWS Amazon Linux 2. With ICU version 67.1 (Debian and PHP 8.1) there are no errors.

$style argument in NumberFormatter() should be int. In v7 $style = NumberFormatter::CURRENCY || NumberFormatter::DECIMAL is equal to true and casts to 1 (it is equal to NumberFormatter::DECIMAL).

The problem with NumberFormatter() can be reproduced on onlinephp.io. Try to execute code few times.

Valid result in this case should be empty string.

Use parent dependency multiply and divide so we can cover the rounding.

Convert non-int multipliers to strings since we can only send int or floats to the \Money\Money class

Resolves #133

Hi!

After upgrading from a previous version our test automation started picking up rounding issues when multiplying and dividing values, only when using \Money\Money::ROUND_UP && \Money\Money::ROUND_DOWN, e.g.:

// Calculation without rounding: 5321.27659574468085

// Returns: 5321 as expected
Money::GBP(2501)->divide(0.47);

// Returning: 5321 when it should return 5322
Money::GBP(2501)->divide(0.47, \Money\Money::ROUND_UP);

After looking into the code of the package we are using the native php round function which does not have ROUND_UP or ROUND_DOWN, after investigating MoneyPHP dependency they have their own private round method which uses ceil and floor.

I'm creating a PR for the fix, for your review.

Issue caused by: https://github.com/cknow/laravel-money/pull/117

Thank you!

From the logs:

WARN PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in vendor/cknow/laravel-money/src/BladeExtension.php on line 76.

In the readme file there is the following example when setting a cast attribute:

$model->money = 10; // 10.00 USD or any other currency defined

But setting $model->money = 10; seem to produce 0.10 USD on the latest version (v7.0.2).

Not sure if it's the readme or the implementation that is incorrect.

Good morning, I'm writing cause I've the following issue. I've a project with installed this package. Let's suppose this code:

use Money\Currency;

$revenueA = new \Cknow\Money\Money(123, new Currency('EUR'));
$revenueB = new \Cknow\Money\Money(123, new Currency('EUR'));

$revenueTotal = $revenueA->add($revenueB);

In my case PHPStorm highlight the last row showing this message: Expected parameter of type '\Money\Money', '\Cknow\Money\Money|null' provided. It expects that the parameter passed to the add method to be of type \Money\Money.

It's annoying cause working with amounts the screen is full of warnings.

Can you please help me about this? Thanks in advance.