Im getting the following error when running the config publish command.

php artisan config:publish anlutro/l4-settings

exception 'Symfony\Component\Debug\Exception\FatalErrorException' with message 'Call to undefined method Illuminate\Config\Repository::package()' in /Users/Thomas/Documents/OAD/Projects/Project/vendor/anlutro/l4-settings/src/ServiceProvider.php:57 Stack trace: #0 /Users/Thomas/Documents/OAD/Projects/Project/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php(116): Illuminate\Foundation\Bootstrap\HandleExceptions->fatalExceptionFromError(Array) #1 [internal function]: Illuminate\Foundation\Bootstrap\HandleExceptions->handleShutdown() #2 {main}

Trying to extend the DatabaseSettingStore class to caching the database results but i don't have any idea how to extend & use the extended class in app. Any help will be appreciated.

MY Store Class

use anlutro\LaravelSettings\DatabaseSettingStore;
class MyStore extends DatabaseSettingStore {
	protected function write(array $data){
			cache()->forget('settings');
			parent::write();
	}
	protected function read(){
		return cache()->rememberForever('settings', function() {
			return parent::read();
		});
	}
}

Don't no where i have to place the below code in laravel. Whether i have to place the below code in Laravel AppServiceProvider?

Setting::extend('mystore', function($app) {
	return $app->make('MyStore');
});

It would be cool to be able to get multiple settings like:

$settings = Setting::get(['finance.vat_rate', 'app_name']);

Return:

[
    'finance' => [
        'vat_rate' => 20,
    ],
    'app_name' => 'My App'
]

Hello. I have my app with a few settings. I want to test the route admin.settings.update: I am currently using the json store.

    public function testSettingsUpdate() 
    {
        $user = factory(User::class)->create();

        // It should mock internally the "save" method
        Settings::fake(); 

        $this->actingAs($user)
            ->post(route('admin.settings.update'), [
                'collections' => [123, 456, 789] 
            ]))
            ->assertOk();

        // Should assert if the Settings::saved() was called
        Settings::assertSaved();
        $this->assertEquals(Settings::get('home.collections.0'), 123);
        $this->assertEquals(Settings::get('home.collections.1'), 456);
        $this->assertEquals(Settings::get('home.collections.2'), 789);
    }

Yes... this could be done with dependency injection. But... The spirit of Laravel is to test easily, do you think?

So... It would be great to have those two methods:

Setting::fake();
Settings::assertSaved();

I have installed this repo to my laravel 5.6.12 and write this code

        setting()->set('foo', 'my value');
        setting()->save();

But my I didn't get anything in my settings table. Is there any thing I am missing?

Laravel version: 5.5.40 PHP version: 7.0

I added this code in a controller to save some settings in database:

`$key = $request->key; $value = $request->value;

    $setting->set($key, $value);

    $setting->setExtraColumns([
        'display_name' => $key,
        'type' => 'text',
    ]);

    $setting->save();

    return $setting->all();`

The problem is that when I save a new setting all the previous settings are resaved in database, making table growing so fast. Please someone tell me what I am doing wrong. Thank you.

Before, the built-in migration run when you run php artisan migrate in Laravel ≥ 5.3 regardless, you couldn't even change the migration. Now you can install the migration to the database/migrations directory if you need it by running php artisan vendor:publish --provider="anlutro\LaravelSettings\ServiceProvider" --tag="migrations" and change the migration.

Resolves #91 and #81.

Also I've fixed the php artisan vendor:publish command syntax in the readme (in Laravel 5.* you need to specify the service class name, not the package name).

I have a problem when try to save a setting using oracle, because the table column is called "key" which is a Oracle reserved word. It's possible in some way set a custom name for package table columns?

Hi, thank you for this amazing package.

I have 1 problem though. Even though I have setExtraColumns, I am not getting the correct value from setting for each user with Setting::all()

What could be the reason?

I'm using Cartalyst/Sentry for authentication. Thank you for your help.

… that will be used before any settings are set, this avoids all settings being set to false to begin with and avoids hardcoding the same defaults in all 'Settings::get()' calls, raises minimum php version to 5.4

In Laravel 5.5, when I run

php artisan vendor:publish --provider="anlutro/l4-settings" --tag="config"

I expect a local configuration file in config/

I see a config file in vendor folder, but this folder is in my .gitignore

Running php artisan vendor:publish publishes the file as expected to config/

Hello,

Recently i've encountered a problem with storing null as a setting value: a new non-null value isnt stored into database if such a key already exists and have a null value.

// This will create a new setting with nullable value
settings()->set([
    'key' => null,
]);
settings()->save();

// That new value will not be stored into database, the actual value will remain "null"
settings()->set([
    'key' => 'value',
]);
settings()->save();

The cause of this problem is that DatabaseSettingStore uses the isset() function to determine if a specific key exists, but that function does not consider null values. I would suggest to use the array_key_exists() function instead:

class DatabaseSettingStore extends SettingStore
{
    protected function write(array $data): void {
        // ...

        foreach ($keys as $key) {
            if (
                array_key_exists($key, $updatedData)
                && array_key_exists($key, $persistedData)
                && (string) $updatedData[$key] !== (string) $persistedData[$key]
            ) {
                $updateData[$key] = $updatedData[$key];
            } elseif (!array_key_exists($key, $insertData)) {
                $deleteKeys[] = $key;
            }

            unset($insertData[$key]);
        }

        // ...
    }
}

A use-case for this improvement is that sometimes (my case :)) you have a single form for the project settings and some of them may not have a value (null by default) and it is handy to just save all validated settings into database, event if some values are null:

$settings = $request->validated();

settings()->set($settings);
settings()->save();

I had to extend the DatabaseSettingStore for some unimportant reasons. So I followed the instructions in the readme and added the a new class:

class CustomDatabaseSettingStore extends Base
{
    public function __construct(Connection $connection)
    {
        parent::__construct(
            $connection,
            config('settings.table'),
            config('settings.keyColumn'),
            config('settings.valueColumn')
        );
    }
    // more code here
}

and I added the following to my AppServiceProvider:

Setting::extend('customDatabaseSettingStore', function ($app) {
    return $app->make(CustomDatabaseSettingStore::class);
});

I have caching enabled, but I found the setting cache suspiciously empty. So I checked, and it turns out that caching settings are never set in the custom store, and I think defaults also don't work. These are usually set in SettingsManager::wrapDriver() which is never called.

I had to add the code from wrapDriver() to my custom store:

class CustomDatabaseSettingStore extends Base
{
    public function __construct(Connection $connection)
    {
        parent::__construct(
            $connection,
            config('settings.table'),
            config('settings.keyColumn'),
            config('settings.valueColumn')
        );

        $this->setDefaults(config('settings.defaults'));

        if (config('settings.enableCache')) {
            $this->setCache(
                app()['cache'],
                config('settings.cacheTtl'),
                config('settings.forgetCacheByWrite')
            );
        }
    }
// more code
}

I think, at the very least, the readme should be updated. I was very surprised that this was needed, especially because it is usually handled by the SettingsManager, which I wouldn't have expected to have to look at. I would prefer if wrapDriver() was somehow called for custom drivers, but it would already be helpful if it were public and easily accessible.

Thanks for this great library.

I current have my settings stored in the database.

I am having a problem where I am using a Database transaction, and the setting does not save, it will only save if I do it outside of the transaction.

Is this a limitation with this package that you cannot save settings (in database) using a DB Transaction?

Thanks

run：setting(['financial' => [] ])->save();

result：throw ErrorException: Array to string conversion in file

I think if set key a empty array ,dont save this key will better ?