Hi.

Installing PhpStorm from Brew doesn't seems to create a symlink. Is there a way to workaround this? Tried a couple of solutions what haven't worked at all.

Thanks for any help.

Hi, nice extension. How should i add custom make commands to the path variable? Currently I get sth. like this for my make:trait command - "Undefined index: trait" Thanks

Deprecation Notice: Class OpenOnMake\OpenFile located in ./vendor/ahuggins/open-on-make/src/OpenFIle.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201

Sorry for keeping it brief, would have looked further into it if I had the time. Please ask if you need more info.

This package is causing an error in my project, could reproduce it in a new project:

laravel new bug-test
cd bug-test
php artisan make:test FooBarTest    # all good - without this package
composer require --dev ahuggins/open-on-make
php artisan make:test FooBarzTest    # error - with this package

Verbose error:

   Symfony\Component\Debug\Exception\FatalThrowableError  : Call to a member function getOption() on null

  at /Users/guido/Developer/personal-projects/bug-test/vendor/laravel/framework/src/Illuminate/Console/Command.php:363
    359|         if (is_null($key)) {
    360|             return $this->input->getOptions();
    361|         }
    362| 
  > 363|         return $this->input->getOption($key);
    364|     }
    365| 
    366|     /**
    367|      * Get all of the options passed to the command.

  Exception trace:

  1   Illuminate\Console\Command::option("unit")
      /Users/guido/Developer/personal-projects/bug-test/vendor/laravel/framework/src/Illuminate/Foundation/Console/TestMakeCommand.php:66

  2   Illuminate\Foundation\Console\TestMakeCommand::getDefaultNamespace("Tests")
      /Users/guido/Developer/personal-projects/bug-test/vendor/laravel/framework/src/Illuminate/Console/GeneratorCommand.php:97

  3   Illuminate\Console\GeneratorCommand::qualifyClass("FooBarzTest")
      [internal]:0

  4   ReflectionMethod::invokeArgs(Object(Illuminate\Foundation\Console\TestMakeCommand))
      /Users/guido/Developer/personal-projects/bug-test/vendor/ahuggins/open-on-make/src/Listeners/OpenOnMake.php:150

  5   OpenOnMake\Listeners\OpenOnMake::determineFilePath()
      /Users/guido/Developer/personal-projects/bug-test/vendor/ahuggins/open-on-make/src/Listeners/OpenOnMake.php:65

  6   OpenOnMake\Listeners\OpenOnMake::handle(Object(Illuminate\Console\Events\CommandFinished))
      /Users/guido/Developer/personal-projects/bug-test/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php:366

  7   call_user_func_array()
      /Users/guido/Developer/personal-projects/bug-test/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php:366

  8   Illuminate\Events\Dispatcher::Illuminate\Events\{closure}("Illuminate\Console\Events\CommandFinished")
      /Users/guido/Developer/personal-projects/bug-test/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php:196

  9   Illuminate\Events\Dispatcher::dispatch("Illuminate\Console\Events\CommandFinished")
      /Users/guido/Developer/personal-projects/bug-test/vendor/laravel/framework/src/Illuminate/Console/Application.php:93

  10  Illuminate\Console\Application::run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
      /Users/guido/Developer/personal-projects/bug-test/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:131

  11  Illuminate\Foundation\Console\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
      /Users/guido/Developer/personal-projects/bug-test/artisan:37

Love this wee package, used if your years.

Seems to now open newly made files in a new window though. I'm using remote - ssh for my development environment. Not sure if that's the issue?

After the artisan command make:observer runs it seems the package falls over:

   ErrorException  : Undefined index: observer

  at C:\www\ryder\vendor\ahuggins\open-on-make\src\Listeners\OpenOnMake.php:45
    41|                 $path = base_path($this->getTestPath($event) . $this->filename($event));
    42|             } elseif ($classType === 'migration') {
    43|                 $path = $this->getLatestMigrationFile();
    44|             } else {
  > 45|                 $path = base_path($this->paths[$classType] . $this->filename($event));
    46|             }
    47|
    48|             exec(
    49|                 config('open-on-make.editor') . ' ' .

  Exception trace:

  1   Illuminate\Foundation\Bootstrap\HandleExceptions::handleError("Undefined index: observer", "C:\www\ryder\vendor\ahuggins\open-on-make\src\Listeners\OpenOnMake.php", [Object(Illuminate\Console\Events\CommandFinished), "observer"])
      C:\www\ryder\vendor\ahuggins\open-on-make\src\Listeners\OpenOnMake.php:45

  2   OpenOnMake\Listeners\OpenOnMake::handle(Object(Illuminate\Console\Events\CommandFinished))
      C:\www\ryder\vendor\laravel\framework\src\Illuminate\Events\Dispatcher.php:379

Clean 5.6 project.

Depending on team workflow, not everyone might want this package enabled. This update provides a new configuration to conditionally disable the event listener via environment:

OPEN_ON_MAKE_ENABLED=false

Was running through a test tutorial and this failed to open the file: php artisan make:test Http/Controllers/Auth/LoginControllerTest

This works: php artisan make:test LoginControllerTest

And this works: php artisan make:test Http/Controllers/Auth/LoginControllerTest.php

I've been getting this error since last update (not sure what version I was on previously) it only happens on some make commands, not all. make:migration is one that it does happen on.

Method Illuminate\Database\Console\Migrations\MigrateMakeCommand::getPath() does not exist

it happens in /vendor/ahuggins/open-on-make/src/Listeners/OpenOnMake.php:139

    137|     public function determineFilePath()
    138|     {
  > 139|         $pathMethod = new \ReflectionMethod($this->getCommandClass(), 'getPath');
    140|         $pathMethod->setAccessible(true);
    141| 
    142|         $qualifyMethod = new \ReflectionMethod($this->getCommandClass(), 'qualifyClass');
    143|         $qualifyMethod->setAccessible(true);

I've not had a chance to dig into it.

I'm getting this error for all artisan make commands:

[2018-09-06 03:13:17] local.ERROR: Symfony\Component\Console\Exception\InvalidArgumentException: The "name" argument does not exist. in /Users/tobyevans/Code/dovetailx/api.dovetailx/vendor/symfony/console/Input/Input.php:110
Stack trace:
#0 /Users/tobyevans/Code/dovetailx/api.dovetailx/vendor/ahuggins/open-on-make/src/Listeners/OpenOnMake.php(68): Symfony\Component\Console\Input\Input->getArgument('name')
#1 /Users/tobyevans/Code/dovetailx/api.dovetailx/vendor/ahuggins/open-on-make/src/Listeners/OpenOnMake.php(45): OpenOnMake\Listeners\OpenOnMake->filename(Object(Illuminate\Console\Events\CommandFinished))
#2 [internal function]: OpenOnMake\Listeners\OpenOnMake->handle(Object(Illuminate\Console\Events\CommandFinished))
#3 /Users/tobyevans/Code/dovetailx/api.dovetailx/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php(379): call_user_func_array(Array, Array)
#4 /Users/tobyevans/Code/dovetailx/api.dovetailx/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php(209): Illuminate\Events\Dispatcher->Illuminate\Events\{closure}('Illuminate\\Cons...', Array)
#5 /Users/tobyevans/Code/dovetailx/api.dovetailx/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php(182): Illuminate\Events\Dispatcher->dispatch('Illuminate\\Cons...', Array, false)
#6 /Users/tobyevans/Code/dovetailx/api.dovetailx/vendor/laravel/framework/src/Illuminate/Console/Application.php(92): Illuminate\Events\Dispatcher->fire(Object(Illuminate\Console\Events\CommandFinished))
#7 /Users/tobyevans/Code/dovetailx/api.dovetailx/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(122): Illuminate\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#8 /Users/tobyevans/Code/dovetailx/api.dovetailx/artisan(35): Illuminate\Foundation\Console\Kernel->handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#9 {main}  

Laravel 5.6

My project is located in a folder with space in the name and this package doesn't work well with this. It opens 2 new empty tabs in visual studio code. To fix this i added double quotes to the file path and it works as expected.

Bumps league/flysystem from 1.1.3 to 1.1.4.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps laravel/framework from 7.26.1 to 7.30.4.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.