Issue Number

Issue humanmade/hm-playbook-theme#530

Description

This change updates the Revisions Widget style bugs and date format.

| Default Style | Hover & Focus | Selected Revision | | ----------- | ----------- | ----------- | | | | |

Steps to Test

1. Navigate to a page with a Revision widget.
2. Test the "Load Revision" button and make sure it displays with a border and color background on focus and hover.
3. Check that the date is displayed in YYYY-MM-DD format.

Acceptance Criteria

• [x] The widget uses YYYY-MM-DD to align with dates formats in the rest of the Playbook
• [x] ~The widget does not include the time of the revision~ Clean up the styling for this to make it more readable
• [x] There is appropriate spacing between the last revision event and the Load Revisions CTA within the widget.
• [x] Has this been tested in multiple browsers
• [x] Has it been accessibility tested
• [x] Have all linters and PHPCS checks been run
• [x] Does the README.md and the Wiki need updating to reflect these changes
• [x] Do any articles on how to update the Playbook in https://playbook.hmn.md/category/updating-the-playbook/ need updating to reflect these changes.

The current build workflow only supports version number-tagged production releases, which makes it difficult to test things on a development instance. To enable better usage on our test instance, this PR implements a GH action to build to a develop-built branch upon merge to this repository's develop branch.

The path to the asset manifest is incorrect following my work in #3,

Asset_Loader\enqueue_asset(
	HM_POST_HISTORY_DIR . 'assets/build/asset-manifest.json',
	'frontend.js',
	// ...

since the file is production-asset-manifest.json, and asset-manifest.json does not exist, Asset Loader silently defaults to trying to load the asset as

{path where it expected manifest to be}/{handle you provided}
HM_POST_HISTORY_DIR . 'assets/build/' . 'frontend.js'

However, since the JS and CSS are built with a hashed filename, that file doesn't exist either—and causes a 404.

Fixes #8

Errors observed in production:

E_USER_NOTICEStyle hm-post-history error [altis.security.browser.file_not_exists]: File for hm-post-history does not exist
/usr/src/app/vendor/altis/browser-security/inc/namespace.php:122
E_USER_NOTICEScript hm-post-history error [altis.security.browser.file_not_exists]: File for hm-post-history does not exist
/usr/src/app/vendor/altis/browser-security/inc/namespace.php:144
E_USER_NOTICEScript hm-post-history error [altis.security.browser.file_not_exists]: File for hm-post-history does not exist
/usr/src/app/vendor/altis/browser-security/inc/namespace.php:144

Xray trace

Built tag 1.4.2 is in use in prod

This PR updates the build process for this plugin to match that of humanmade/datavis-block, where we used a manual fully-specified .eslintrc.js to work around the circular dependency issues in the HM coding standards. Until we fix those upstream, this is stable, matches our standards, passes lint on this repo, and should unblock automated build deploys.

• Avoids a recursive dependency error that breaks the release action
• Will not be hard to switch back to HM coding standards package if needed
• Only difference is () around arrow functions which I am mandating as a dictatorial package maintainer

I'd accidentally tracked rendered assets, which is not something I want to do. Without an established release-generation system (which seems like overkill for such a small plugin) it's far too easy for these assets to get out out sync--the developer making changes must always remember to clear out dev assets, generate new prod assets, commit them, etc. In this case, it seems like the better solution is to rely on sites using this plugin (which, at the moment, is only one of our internal sites) to build the assets on deploy.

This PR removes the erroneously-committed assets and adds a note to the README about building assets on deploy.

The margins from v1 of this widget are not needed in the newer design and cause the load more button to appear out of alignment

Relates to humanmade/hm-playbook-theme#530