@Alexia, A wonderful tool, it has saved a lot of time - for me!

A suggestion and a tested 'patch' to eliminate some of the "php7mar" report noise:

Change file php7mar/classes/tests/critical.php

-$regex = "#(?:(?:->|\\$)\\$[a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]+|::\\$[a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]+\[.+?\]\(.*?\))#i";
+$regex = "#(?:(?:\\$)\\$[a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]+|(?:->|\\$)\\$[a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]+\[.+?\]|::\\$[a-zA-Z_\\x7f-\\xff][a-zA-Z0-9_\\x7f-\\xff]+\[.+?\]\(.*?\))#i";

Before Patch Report:

2015-07-05T20:36:10+09:30
Scanning /root/drupal6-2015/al-orig/cck/content.module
Including file extensions: php,inc,module
Processed 2508 lines contained in 1 files.
Processing took 0.039178133010864 seconds.

# critical
#### /root/drupal6-2015/al-orig/cck/content.module
* variableInterpolation
 * Line 227: `      $node->$key = $value;`
 * Line 234: `        $node->$key = $value;`
 * Line 240: `        $node->$key = $value;`
 * Line 341: `  if (isset($node->$field['field_name'])) {`
 * Line 342: `    $items = $node->$field['field_name'];`
 * Line 351: `      $node->$field['field_name'] = $items;`
 * Line 352: `      $$this->{protocolVersion} = $version;  // peter`
 * Line 353: `      $$varname = $v;  // Peter`
 * Line 668: `        $node->$field['field_name'] = $items;`
 * Line 816: `      if (isset($node->translation_source->$field['field_name'])) {`
 * Line 817: `        $addition[$field['field_name']] = $node->translation_source->$field['field_name'];`
 * Line 943: `          if (isset($node->$field_name)) {`
 * Line 980: `        if ($field['multiple'] && isset($node->$field['field_name'])) {`
 * Line 986: `          foreach ($node->$field['field_name'] as $delta => $item) {`
 * Line 1068: `    if (!isset($object->$field) && !count($update) && isset($info['default'])) {`
 * Line 1069: `      $object->$field = $info['default'];`
 * Line 1075: `      unset($object->$field);`
 * Line 1078: `    if (isset($object->$field) || array_key_exists($field, $object)) {`
 * Line 1080: `      if (isset($object->$field)) {`
 * Line 1083: `          $values[] = $object->$field;`
 * Line 1086: `          $values[] = serialize($object->$field);`
 * Line 1110: `      $values[] = $object->$key;`
 * Line 1120: `        $object->$field = db_last_insert_id($table, $field);`
 * Line 1143: `    $items = isset($node->$field['field_name']) ? $node->$field['field_name'] : array();`
 * Line 1158: `    if (isset($node->$field['field_name']) || count($items)) {`
 * Line 1159: `      $node->$field['field_name'] = $items;`
 * Line 1179: `      $items = isset($node->$field['field_name']) ? $node->$field['field_name'] : array();`
 * Line 1187: `      if (isset($node->$field['field_name'])) {`
 * Line 1188: `        $node->$field['field_name'] = $items;`

After Patch:

2015-07-05T20:37:05+09:30
Scanning /root/drupal6-2015/al-orig/cck/content.module
Including file extensions: php,inc,module
Processed 2508 lines contained in 1 files.
Processing took 0.039650917053223 seconds.

# critical
#### /root/drupal6-2015/al-orig/cck/content.module
* variableInterpolation
 * Line 341: `  if (isset($node->$field['field_name'])) {`
 * Line 342: `    $items = $node->$field['field_name'];`
 * Line 351: `      $node->$field['field_name'] = $items;`
 * Line 352: `      $$this->{protocolVersion} = $version;  // peter`
 * Line 353: `      $$varname = $v;  // Peter`
 * Line 668: `        $node->$field['field_name'] = $items;`
 * Line 816: `      if (isset($node->translation_source->$field['field_name'])) {`
 * Line 817: `        $addition[$field['field_name']] = $node->translation_source->$field['field_name'];`
 * Line 980: `        if ($field['multiple'] && isset($node->$field['field_name'])) {`
 * Line 986: `          foreach ($node->$field['field_name'] as $delta => $item) {`
 * Line 1143: `    $items = isset($node->$field['field_name']) ? $node->$field['field_name'] : array();`
 * Line 1158: `    if (isset($node->$field['field_name']) || count($items)) {`
 * Line 1159: `      $node->$field['field_name'] = $items;`
 * Line 1179: `      $items = isset($node->$field['field_name']) ? $node->$field['field_name'] : array();`
 * Line 1187: `      if (isset($node->$field['field_name'])) {`
 * Line 1188: `        $node->$field['field_name'] = $items;`

This simple change avoids a number of 'unneeded' reports on the PHP Uniform Variable Syntax changes. The main target being those changed “variable variable” syntax issues = $$foo['bar'], $foo->$bar['baz'], and Foo::$bar['baz'].

As soon as the folder contains a space, I've got this notice continuously (Windows 7 with wampserver 3.0.0): Notice: Undefined index: line in D:\wamp64\\www\php7mar\mar.php on line 126

I use some other file extensions for PHP files, notably .inc. I created a -x option to specify file extensions to consider PHP files. Defaults to just .php, so the default use case, commands, etc will not change.

Ex:

    php mar.php -f=~/mycode/ 

Will run looking for and processing for just ".php" files as before

    php mar.php -f=~/mycode/ -x="php,inc"

Will run looking for and processing ".php" and ".inc" files

When running mar.php i get the following error: PHP Parse error: syntax error, unexpected '[', expecting ')' in /usr/local/share/php7mar/mar.php on line 58

Maybe php7mar itelf needs PHP 7? I don't see any mention of that in the readme.

PHP 4 style constructors:

PHP 4 style constructors (methods that have the same name as the class they are defined in) are deprecated, and will be removed in the future. PHP 7 will emit E_DEPRECATED if a PHP 4 constructor is the only constructor defined within a class. Classes that implement a __construct()method are unaffected.

// Methods with the same name as their class will not be constructors in a future version of PHP
class FooBar {
        var $test = 42;

        function set() {}

        function FooBar() {
                // NOP
        }
}

will be reported as follows:

* oldClassConstructors
 * Line 129: `  function FooBar() {`

and PHP7 will complain:

Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP

Hey, great project, thanks so far :) Under Windows Server there is a small problem with the name of the generated report file:

In reporter.php at L78 (https://github.com/Alexia/php7mar/blob/master/classes/reporter.php#L78): $this->fullFilePath = $this->reportFolder.date('Y-m-d H:i:s ').basename($this->projectPath, '.php').".md";

The ':' inside the date-string lead to a filesystem error as ':' is not allowed inside file names under windows. I fixed it locally by using dots instead but maybe you can change it globally so it is working under all environments by default?

Thanks and regards

Comments should not be scanned:

####/XXXXXX/XXXXXXXX.php
* reservedNames
 * Line 99:                                                     // get class object
 * Line 179:                            // get class object

GitHub changed the way Markdown headings are parsed, so this change fixes it.

See bryant1410/readmesfix for more information.

Tackles bryant1410/readmesfix#1

http://php.net/manual/en/migration70.incompatible.php#migration70.incompatible.other.new-by-ref

Add a check for the following use of new operator which is no longer supported:

<?php
class C {}
$c =& new C;
?>

Parse error: syntax error, unexpected 'new' (T_NEW) in /tmp/test.php on line 3

This code will generate the following entry in the report:

* newOperatorWithReference
 * Line 123: `$c =& new C;`
 * Line 124: `$c =&new C;`

When using the '-r' option, eg -r="/foo/bar" the report was not saved to that location. Instead all reports were saved in /foo prefixed with bar: Report located at: /foo/bar2015-12-08 ...

This pull request fixes this issue.

Reports are now saved to /foo/bar/2015-...

• Adds spaces between headings because some markdown parsers require that
• Add code blocks so that it doesn't fail horribly (e.g when posting results on gihub's gist)

I did a lot of tests and i don't find a good resolution of my problems, maybe the code has to be atualized!!

A lot of questions of PHP 7 is ignored by de MARS, like constructs and others changes that happens into PHP 7

Other problem is the lexical sintaxs that is not verified by MARS. In my case, is a huge project and the MARS can't be used! But the project has a nice ideia!

This function was actually DEPRECATED in PHP 5.3.0.

You can see the deprecated function list containing split in https://www.php.net/manual/en/migration53.deprecated.php under Migrating from PHP 5.2.x to PHP 5.3.x, but the function was "only" removed from php 7.0,

Migration guide of phpmanual(5.6.x to 7.0.x) does not include this for some reason.

I'm getting results like these:

/var/www/something/FileByteStream.php
deprecatedFunctions
Line 42: if (function_exists('get_magic_quotes_runtime') && @get_magic_quotes_runtime() == 1) {

It looks like the script falsely identifies get_magic_quotes_runtime as being a deprecated function.

It's not: https://www.php.net/manual/en/function.get-magic-quotes-runtime.php whereare magic_quotes_runtime is indeed deprecated: https://www.php.net/manual/en/function.magic-quotes-runtime.php

I've extented the regex so that the target shouldn't be preceded by a underscore.

@Alexia: I have seen improvements in several forks:

• https://github.com/Alexia/php7mar/network

It is possible to update the main code and solve bugs?

Thanks in advance.

It is understood that intention is not supported by this tool but since list() has changed dramatically, the tool should at least detect and report its use. The intention is not even important here. What's important is that the output from list() was reversed.